Page MenuHomeFreeBSD
Feed Advanced Search

Apr 19 2023

rrs requested review of D39699: tcp: rack the request level logging is a bit too noisy when doing point logging..
Apr 19 2023, 5:53 PM
rrs committed rG7a842346c3cd: tcp: Rack can crash with the new non-TSO fix.. (authored by rrs).
tcp: Rack can crash with the new non-TSO fix..
Apr 19 2023, 5:17 PM
rrs closed D39690: tcp: Rack can crash with the new non-TSO fix...
Apr 19 2023, 5:17 PM
rrs committed rG303246dcdf44: We have a TCP_LOG_CONNEND log that should come out at the very last log of… (authored by rrs).
We have a TCP_LOG_CONNEND log that should come out at the very last log of…
Apr 19 2023, 4:54 PM
rrs closed D39693: tcp: Ending BB logs not always coming out.
Apr 19 2023, 4:54 PM
rrs updated the diff for D39693: tcp: Ending BB logs not always coming out.

Ensure it compiles when we don't have TCP_ACCOUNTING on

Apr 19 2023, 3:47 PM
rrs updated the diff for D39693: tcp: Ending BB logs not always coming out.

fix stray space

Apr 19 2023, 3:30 PM
rrs requested review of D39693: tcp: Ending BB logs not always coming out.
Apr 19 2023, 3:27 PM
rrs requested review of D39690: tcp: Rack can crash with the new non-TSO fix...
Apr 19 2023, 1:03 PM
rrs accepted D39436: trpt: fix logging.
Apr 19 2023, 11:15 AM
rrs accepted D39591: tcp: improve logging for PRUs .
Apr 19 2023, 11:13 AM
rrs committed rG960985a209f2: tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN… (authored by rrs).
tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN…
Apr 19 2023, 11:10 AM
rrs closed D39672: tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN however our syncache is not aware of that flag..
Apr 19 2023, 11:10 AM

Apr 18 2023

rrs requested review of D39672: tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN however our syncache is not aware of that flag..
Apr 18 2023, 8:18 PM
rrs closed D39653: tcp: Inconsistent use of hpts_calling flag.
Apr 18 2023, 4:02 PM
rrs committed rG2ad584c5551d: tcp: Inconsistent use of hpts_calling flag (authored by rrs).
tcp: Inconsistent use of hpts_calling flag
Apr 18 2023, 3:58 PM
rrs updated the diff for D39653: tcp: Inconsistent use of hpts_calling flag.

Almost forgot, when going through the compressed ack path we will need to possibly nuke the flag too if
output did not occur...

Apr 18 2023, 2:13 PM
rrs requested review of D39653: tcp: Inconsistent use of hpts_calling flag.
Apr 18 2023, 1:08 PM
rrs committed rG37229fed38c6: tcp: Blackbox logging and tcp accounting together can cause a crash. (authored by rrs).
tcp: Blackbox logging and tcp accounting together can cause a crash.
Apr 18 2023, 12:40 PM
rrs closed D39622: tcp: Blackbox logging and tcp accounting together can cause a crash..
Apr 18 2023, 12:40 PM

Apr 17 2023

rrs updated the diff for D39622: tcp: Blackbox logging and tcp accounting together can cause a crash..

Opps lets get the sets of the log union in the right place.

Apr 17 2023, 7:11 PM
rrs requested review of D39622: tcp: Blackbox logging and tcp accounting together can cause a crash..
Apr 17 2023, 7:06 PM

Apr 14 2023

rrs closed D39576: tcp: stack unloading crash in rack and bbr.
Apr 14 2023, 7:52 PM
rrs committed rG3cc7b6673280: tcp: stack unloading crash in rack and bbr (authored by rrs).
tcp: stack unloading crash in rack and bbr
Apr 14 2023, 7:44 PM
rrs requested review of D39576: tcp: stack unloading crash in rack and bbr.
Apr 14 2023, 6:55 PM
rrs accepted D39574: tcp_hpts: use queue(9) STAILQ for the input queue.
Apr 14 2023, 6:03 PM
rrs closed D39565: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing..
Apr 14 2023, 1:34 PM
rrs committed rG9903bf34f01f: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing (authored by rrs).
tcp: rack pacing has some caveats that need to be obeyed when LRO is missing
Apr 14 2023, 1:34 PM

Apr 13 2023

rrs requested review of D39565: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing..
Apr 13 2023, 8:17 PM
rrs closed D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 13 2023, 1:30 PM
rrs committed rG25685b753752: TCP: Misc cleanups of tcp_subr.c (authored by rrs).
TCP: Misc cleanups of tcp_subr.c
Apr 13 2023, 1:30 PM

Apr 12 2023

rrs added a comment to D39501: TCP: Misc cleanups of tcp_subr.c.

Would be nice to know what the problem is you are experiencing with the DSCP for IPv6.

Apr 12 2023, 9:00 PM
rrs added inline comments to D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 12 2023, 5:42 PM
rrs updated the diff for D39501: TCP: Misc cleanups of tcp_subr.c.

Address Richard and Michaels comments by letting sleeping dogs lie :)

Apr 12 2023, 5:41 PM
rrs added inline comments to D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 12 2023, 5:26 PM
rrs added inline comments to D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 12 2023, 3:43 PM
rrs committed rG1073f416576b: tcp_lro: When processing compressed acks lets support the new early wake… (authored by rrs).
tcp_lro: When processing compressed acks lets support the new early wake…
Apr 12 2023, 3:35 PM
rrs closed D39502: tcp_lro: When processing compressed acks lets support the new early wake feature for rack..
Apr 12 2023, 3:35 PM
rrs accepted D39516: tcp: make net.inet.tcp.functions_default vnet specific.
Apr 12 2023, 3:16 PM

Apr 11 2023

rrs requested review of D39502: tcp_lro: When processing compressed acks lets support the new early wake feature for rack..
Apr 11 2023, 2:35 PM
rrs added reviewers for D39501: TCP: Misc cleanups of tcp_subr.c: glebius, gallatin.
Apr 11 2023, 1:32 PM
rrs requested review of D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 11 2023, 1:32 PM

Apr 10 2023

rrs committed rGa2b33c9a7a95: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces… (authored by rrs).
tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces…
Apr 10 2023, 8:34 PM
rrs closed D39494: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces with no LRO) does not work correctly..
Apr 10 2023, 8:34 PM
rrs added a reviewer for D39494: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces with no LRO) does not work correctly.: tuexen.
Apr 10 2023, 8:11 PM
rrs requested review of D39494: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces with no LRO) does not work correctly..
Apr 10 2023, 8:11 PM

Apr 7 2023

rrs accepted D39435: tcp: pass tcpcb in the tfb_tcp_ctloutput() method instead of inpcb.
Apr 7 2023, 7:05 PM
rrs accepted D39434: tcp: reduce argument list to functions that pass a segment.
Apr 7 2023, 7:03 PM
rrs accepted D39433: tcp: retire tfb_tcp_hpts_do_segment().
Apr 7 2023, 7:02 PM
rrs closed D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 7 2023, 2:22 PM
rrs committed rG945f9a7cc9dc: tcp: misc cleanup of options for rack as well as socket option logging. (authored by rrs).
tcp: misc cleanup of options for rack as well as socket option logging.
Apr 7 2023, 2:16 PM
rrs accepted D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 7 2023, 12:53 PM

Apr 6 2023

rrs updated the diff for D39427: tcp: misc cleanup of options for rack as well as socket option logging..

Update comments and spacing per cc's request. I do not update padding since the set of rack
changes is *not* intended to ever be MFC'd.

Apr 6 2023, 12:17 PM
rrs added inline comments to D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 6 2023, 12:16 PM

Apr 5 2023

rrs accepted D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 5 2023, 3:28 PM
rrs updated the diff for D39427: tcp: misc cleanup of options for rack as well as socket option logging..

One missed peak_rate removal ...

Apr 5 2023, 3:28 PM
rrs requested review of D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 5 2023, 2:32 PM
rrs closed D39402: Update rack to the latest code used at NF..
Apr 5 2023, 2:29 PM
rrs accepted D39402: Update rack to the latest code used at NF..
Apr 5 2023, 2:29 PM

Apr 4 2023

rrs committed rG030434acaf46: Update rack to the latest code used at NF. (authored by rrs).
Update rack to the latest code used at NF.
Apr 4 2023, 8:06 PM
rrs updated the diff for D39402: Update rack to the latest code used at NF..

Fix another niggle from Gleb, after we seen *ptr == NULL we don't need to set
*ptr to NULL.

Apr 4 2023, 7:51 PM
rrs updated the diff for D39402: Update rack to the latest code used at NF..

Fix rack_init() bug Gleb found, We need to look at *ptr not ptr in our null check

Apr 4 2023, 7:42 PM
rrs updated the diff for D39402: Update rack to the latest code used at NF..

Opps missed one sysctl change that has to be in.

Apr 4 2023, 1:39 PM
rrs closed D39210: Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features..

Its in Freebsd now..

Apr 4 2023, 1:07 PM
rrs requested review of D39402: Update rack to the latest code used at NF..
Apr 4 2023, 1:04 PM
rrs committed rG73ee5756dee6: Fixes in the tcp infrastructure with respect to stack changes as well as other… (authored by rrs).
Fixes in the tcp infrastructure with respect to stack changes as well as other…
Apr 4 2023, 12:32 PM

Mar 24 2023

rrs accepted D39235: LRO: improve IPv4/IPv6 packet header checks.
Mar 24 2023, 10:44 AM

Mar 23 2023

rrs accepted D36887: tcp: restore some memory savings associated with TIME_WAIT state.
Mar 23 2023, 1:16 PM
rrs accepted D39216: netinet tests: Add error handling tests for UDP with v4-mapped sockets.
Mar 23 2023, 1:14 PM

Mar 22 2023

rrs updated the diff for D39210: Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features..

Opps the tailq hash needs to be commented out until I update rack with those files :)

Mar 22 2023, 6:50 PM
rrs closed D38831: Move access to tcp's t_logstate into inline functions and provide new tracepoint and bbpoint capabilities..
Mar 22 2023, 6:48 PM
rrs accepted D38831: Move access to tcp's t_logstate into inline functions and provide new tracepoint and bbpoint capabilities..
Mar 22 2023, 6:48 PM
rrs requested review of D39210: Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features..
Mar 22 2023, 4:58 PM

Mar 16 2023

rrs committed rG69c7c8119058: Move access to tcp's t_logstate into inline functions and provide new… (authored by rrs).
Move access to tcp's t_logstate into inline functions and provide new…
Mar 16 2023, 3:45 PM

Mar 10 2023

rrs updated the diff for D38831: Move access to tcp's t_logstate into inline functions and provide new tracepoint and bbpoint capabilities..

Since we now allow TCP_ACCOUNTING lets make sure it compiles.

Mar 10 2023, 4:04 PM
rrs updated the diff for D38831: Move access to tcp's t_logstate into inline functions and provide new tracepoint and bbpoint capabilities..

This addresses Gleb's comment on the u_x_ type and also creates TCP_ACCOUNTING to address cc's comments
on size.

Mar 10 2023, 3:21 PM
rrs added inline comments to D38831: Move access to tcp's t_logstate into inline functions and provide new tracepoint and bbpoint capabilities..
Mar 10 2023, 3:18 PM

Feb 28 2023

rrs requested review of D38831: Move access to tcp's t_logstate into inline functions and provide new tracepoint and bbpoint capabilities..
Feb 28 2023, 10:32 PM

Feb 20 2023

rrs accepted D38646: tcp_bblog: sync tcp_log_events with Netflix tree.
Feb 20 2023, 7:05 PM

Feb 6 2023

rrs accepted D38380: ktls: Avoid spurious calls to ktls_disable_ifnet().
Feb 6 2023, 3:40 PM

Jan 10 2023

rrs accepted D37903: Build RACK and BBR TCP stacks as a part of LINT.
Jan 10 2023, 9:07 PM

Jan 5 2023

rrs committed rG26bdd35c39d8: rack and bbr not loading if TCP_RATELIMIT is not configured. (authored by rrs).
rack and bbr not loading if TCP_RATELIMIT is not configured.
Jan 5 2023, 5:02 PM
rrs closed D37954: rack and bbr not loading if TCP_RATELIMIT is not configured..
Jan 5 2023, 5:02 PM
rrs requested review of D37954: rack and bbr not loading if TCP_RATELIMIT is not configured..
Jan 5 2023, 2:23 PM

Dec 14 2022

rrs committed rG2e2a1c313935: Opps take out a stray left behind printf that was (authored by rrs).
Opps take out a stray left behind printf that was
Dec 14 2022, 9:12 PM
rrs closed D37622: Rack cannot be loaded without cc_newreno compiled into the kernel..
Dec 14 2022, 8:40 PM
rrs committed rGe2e088ae86da: Rack cannot be loaded without cc_newreno compiled into the kernel. (authored by rrs).
Rack cannot be loaded without cc_newreno compiled into the kernel.
Dec 14 2022, 8:40 PM

Dec 7 2022

rrs requested review of D37622: Rack cannot be loaded without cc_newreno compiled into the kernel..
Dec 7 2022, 3:38 PM

Nov 22 2022

rrs accepted D37112: tcp: Don't try to disconnect a socket multiple times..
Nov 22 2022, 2:10 PM

Nov 3 2022

rrs accepted D37016: tcp: sync with latest linux tcp_info struct.
Nov 3 2022, 4:00 PM

Oct 24 2022

rrs committed rG31bc602ff811: Rack and BBR broken with the new timewait state purge. (authored by rrs).
Rack and BBR broken with the new timewait state purge.
Oct 24 2022, 7:50 PM
rrs closed D37080: Rack and BBR broken with the new timewait state purge..
Oct 24 2022, 7:50 PM

Oct 21 2022

rrs requested review of D37080: Rack and BBR broken with the new timewait state purge..
Oct 21 2022, 1:19 PM

Oct 4 2022

rrs committed rGcd84e78f09ec: tcp idle reduce does not work for a server. (authored by rrs).
tcp idle reduce does not work for a server.
Oct 4 2022, 11:11 AM
rrs closed D36721: tcp idle reduce does not work for a server..
Oct 4 2022, 11:10 AM

Oct 3 2022

rrs accepted D36858: time(3): Align fast clock times to avoid firing multiple timers..
Oct 3 2022, 3:08 PM
rrs accepted D36721: tcp idle reduce does not work for a server..

I have a vage recollection, of something along these lines having been checked in "recently" (within last 2 years?)

Ah, here - https://reviews.freebsd.org/D25016

was that incomplete, or not implemented properly?

It shouldn't matter that much if we reduce cwnd right at the receipt of a new segment (in tcp_input), or just prior of sending out the next segment (in tcp_output)?

Oct 3 2022, 11:21 AM
rrs accepted D36863: tcp: allow window scale and timestamps to be toggled individually.
Oct 3 2022, 11:16 AM
rrs accepted D36862: Honor the drop_synfin sysctl variable in TIMEWAIT state.
Oct 3 2022, 11:15 AM

Sep 27 2022

rrs committed rG08af8aac2a61: Tcp progress timeout (authored by rrs).
Tcp progress timeout
Sep 27 2022, 5:40 PM