Page MenuHomeFreeBSD
Differential D39516

tcp: make net.inet.tcp.functions_default vnet specific
ClosedPublic
Actions

Authored by tuexen on Apr 12 2023, 9:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 28 2024, 4:18 PM
Unknown Object (File)
Feb 21 2024, 5:06 PM
Unknown Object (File)
Dec 20 2023, 7:38 AM
Unknown Object (File)
Dec 10 2023, 5:59 PM
Unknown Object (File)
Nov 9 2023, 1:45 PM
Unknown Object (File)
Oct 22 2023, 3:47 AM
Unknown Object (File)
Oct 10 2023, 5:54 PM
Unknown Object (File)
Sep 6 2023, 5:11 AM
View All 25 Files
Subscribers
imp
melifaro
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
glebius
rrs
rscheff
cc
Group Reviewers
transport
Commits
rGc687f21add77: tcp: make net.inet.tcp.functions_default vnet specific
Summary

Allow the sysctl-variable net.inet.tcp.functions_default to be vnet specific.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 12 2023, 9:08 AM
Herald added a reviewer: transport. · View Herald TranscriptApr 12 2023, 9:08 AM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Apr 12 2023, 9:08 AM
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Apr 12 2023, 9:42 AM
zarychtam_plan-b.pwste.edu.pl added a comment.Apr 12 2023, 9:59 AM

Thanks for taking care of the problem. Will it grow vnet memory requirements? Can the change be applied safely to stable/13? Are any plans to MFC when gets committed to HEAD ?

tuexen added a comment.Apr 12 2023, 10:08 AM
In D39516#899644, @zarychtam_plan-b.pwste.edu.pl wrote:

Thanks for taking care of the problem. Will it grow vnet memory requirements? Can the change be applied safely to stable/13? Are any plans to MFC when gets committed to HEAD ?

One pointer gets virtualized, so the memory requirements should be about the same. I think it can be MFCed to stable/13. Will test it and MFC, if it is actually works. Please note that this patch depends on D39514.

rrs accepted this revision.Apr 12 2023, 3:16 PM
This revision is now accepted and ready to land.Apr 12 2023, 3:16 PM
cc accepted this revision.Apr 12 2023, 3:36 PM

Looks good to me. If the ')' char can be removed as pointed out in my inline comment, that will be better!

sys/netinet/tcp_subr.c
1333

Shall remove this '(' character.

Closed by commit rGc687f21add77: tcp: make net.inet.tcp.functions_default vnet specific (authored by tuexen). · Explain WhyApr 12 2023, 4:07 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGc687f21add77: tcp: make net.inet.tcp.functions_default vnet specific.
tuexen added inline comments.Apr 12 2023, 4:14 PM
sys/netinet/tcp_subr.c
1333

Committed separately: https://cgit.FreeBSD.org/src/commit/?id=2ba2849c8275d4aeb2e4ca04aafaf89f1962910b

Revision Contents
Changeset List

PathSize
sys/
netinet/
34 lines

Diff 120218

View Options

sys/netinet/tcp_subr.c

Loading...