I have one note, though. The "PRU" in the commit message made me notice that tcp_bblog_pru() again started to use this PRU_XXX namespace. If you started using it again, it needs to get out of in_kdtrace.h. But I'd rather suggest to create some own namespace for BB logging and forget this legacy. The long story of PRU_XXX namespace can be found in a comment in in_kdtrace.h.

In D39591#901811, @glebius wrote:

I like the combing of all these functions prologue.

I have one note, though. The "PRU" in the commit message made me notice that tcp_bblog_pru() again started to use this PRU_XXX namespace. If you started using it again, it needs to get out of in_kdtrace.h. But I'd rather suggest to create some own namespace for BB logging and forget this legacy. The long story of PRU_XXX namespace can be found in a comment in in_kdtrace.h.

We can move things around as long as the numbers are not changed. I use them in the wireshark dissector: packet-bblog.c:179. Let us discuss this on Thursday in the transport call.

rrs accepted this revision.Apr 19 2023, 11:13 AM

This revision is now accepted and ready to land.Apr 19 2023, 11:13 AM

Closed by commit rGc2399dd2e227: tcp: improve BBLoging for PRUs (authored by tuexen). · Explain WhyMay 6 2023, 9:15 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGc2399dd2e227: tcp: improve BBLoging for PRUs.