Differential D39622

tcp: Blackbox logging and tcp accounting together can cause a crash.
ClosedPublic
Actions

Authored by rrs on Apr 17 2023, 7:06 PM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG37229fed38c6: tcp: Blackbox logging and tcp accounting together can cause a crash.

Summary

If you currently turn BB logging on and in combination have TCP Accounting on we can get a
crash where we have no NULL check and we run out of memory. Also lets make sure we
don't do a divide by 0 in calculating any BB ratios.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rrs created this revision.Apr 17 2023, 7:06 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptApr 17 2023, 7:06 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

rrs requested review of this revision.Apr 17 2023, 7:06 PM

Opps lets get the sets of the log union in the right place.

tuexen accepted this revision.Apr 17 2023, 8:33 PM

This revision is now accepted and ready to land.Apr 17 2023, 8:33 PM

Closed by commit rG37229fed38c6: tcp: Blackbox logging and tcp accounting together can cause a crash. (authored by rrs). · Explain WhyApr 18 2023, 12:40 PM

This revision was automatically updated to reflect the committed changes.

rrs added a commit: rG37229fed38c6: tcp: Blackbox logging and tcp accounting together can cause a crash..

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2023, 12:40 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_log_buf.c

38 lines

Diff 120560

View Options

tcp: Blackbox logging and tcp accounting together can cause a crash.ClosedPublicActions