Page MenuHomeFreeBSD
Differential D39622

tcp: Blackbox logging and tcp accounting together can cause a crash.
ClosedPublic
Actions

Authored by rrs on Apr 17 2023, 7:06 PM.
Tags
None
Referenced Files
F154226060: D39622.id120497.diff
Mon, Apr 27, 6:29 AM
Unknown Object (File)
Sat, Apr 25, 9:18 AM
Unknown Object (File)
Fri, Apr 24, 12:02 AM
Unknown Object (File)
Wed, Apr 22, 9:22 AM
Unknown Object (File)
Tue, Apr 21, 8:18 AM
Unknown Object (File)
Sat, Apr 18, 5:53 PM
Unknown Object (File)
Sat, Apr 18, 5:53 PM
Unknown Object (File)
Sat, Apr 18, 5:53 PM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rG37229fed38c6: tcp: Blackbox logging and tcp accounting together can cause a crash.
Summary

If you currently turn BB logging on and in combination have TCP Accounting on we can get a
crash where we have no NULL check and we run out of memory. Also lets make sure we
don't do a divide by 0 in calculating any BB ratios.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
sys/
netinet/
38 lines

Diff 120498

View Options

sys/netinet/tcp_log_buf.c

Loading...