Paths

Table of Contentst

Differential D39436

trpt: fix logging
ClosedPublic
Actions

Authored by tuexen on Apr 5 2023, 4:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 23, 2:24 PM

	Unknown Object (File)
	Tue, Apr 23, 7:51 AM

	Unknown Object (File)
	Sun, Apr 7, 9:07 PM

	Unknown Object (File)
	Mar 16 2024, 4:54 AM

	Unknown Object (File)
	Jan 27 2024, 8:50 PM

	Unknown Object (File)
	Jan 27 2024, 2:43 AM

	Unknown Object (File)
	Jan 27 2024, 2:43 AM

	Unknown Object (File)
	Jan 27 2024, 2:43 AM

View All 41 Files

Subscribers

Details

Reviewers

rrs
glebius
rscheff
cc

Group Reviewers

Commits

rGd7339c42673a: trpt: fix several bugs and add deprecation notice

Summary

This patch against stable/13 fixes several issues related to the trpt utility including:

Fix the computation of the TCP payload bytes, in particular when TCP options are present or IPv4 is used.
Fix the logging of incoming packets.
Improve the logging of outgoing packets.
Fix the logging of timers, in particular add support for logging of the delayed ack timer.

Also add a deprecation note, since support for this utility has been removed from the main branch. Therefore, this will be a direct commit to stable/13.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 5 2023, 4:54 PM

Herald added a reviewer: transport. · View Herald TranscriptApr 5 2023, 4:54 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Apr 5 2023, 4:54 PM

Add changes to the man page.

tuexen edited the summary of this revision. (Show Details)Apr 13 2023, 2:54 PM

tuexen added reviewers: rrs, glebius, rscheff, cc.

tuexen edited the summary of this revision. (Show Details)

rrs accepted this revision.Apr 19 2023, 11:15 AM

This revision is now accepted and ready to land.Apr 19 2023, 11:15 AM

cc accepted this revision.Apr 19 2023, 7:50 PM

No objection

Closed by commit rGd7339c42673a: trpt: fix several bugs and add deprecation notice (authored by tuexen). · Explain WhyApr 20 2023, 10:16 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGd7339c42673a: trpt: fix several bugs and add deprecation notice.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

9 lines

13 lines

28 lines

6 lines

20 lines

usr.sbin/

trpt/

31 lines

10 lines

Diff 120777

sys/netinet/tcp_debug.c

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_output.c

Loading...

sys/netinet/tcp_timer.h

Loading...

sys/netinet/tcp_timer.c

Loading...

usr.sbin/trpt/trpt.8

Loading...

usr.sbin/trpt/trpt.c

Loading...