Very small complaints only.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 18 2019
Aug 18 2019
Aug 11 2019
Aug 11 2019
D21211: Change w(1) to compute FROM (host) field size dynamically is now accepted and ready to land.
D21211: Change w(1) to compute FROM (host) field size dynamically is now accepted and ready to land.
Jul 31 2019
Jul 31 2019
markm added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
LGTM otherwise.
Jun 27 2019
Jun 27 2019
D20780: Add support for getting early entropy from the UEFI RNG protocol is now accepted and ready to land.
Presuming all the testing works :-)
Jun 22 2019
Jun 22 2019
Still LGTM :-)
Jun 20 2019
Jun 20 2019
D19918: sys: Remove DEV_RANDOM device option is now accepted and ready to land.
No objection from me.
Jun 9 2019
Jun 9 2019
Jun 7 2019
Jun 7 2019
None job, thanks!
Jun 3 2019
Jun 3 2019
May 31 2019
May 31 2019
May 30 2019
May 30 2019
May 28 2019
May 28 2019
May 23 2019
May 23 2019
Good move!
May 19 2019
May 19 2019
This is a step in a direction that I've been wanting to doo for quite some time; pin multiple output generators to processors. There is more, but I need to write it in detail first.
May 12 2019
May 12 2019
Looks OK to me!
May 8 2019
May 8 2019
I'm OK with this.
Apr 18 2019
Apr 18 2019
LGTM.
Apr 11 2019
Apr 11 2019
Against my better judgement, I kept the !DEV_RANDOM case as some folks insisted on being able to use preferred tools (ssh) even on insecure embedded hardware. I'm happy to se you fix it, if it means I don't get the flak ]:->
Apr 6 2019
Apr 6 2019
Backport fixes from FreeBSD-12 to help the random(4) device thread
Apr 5 2019
Apr 5 2019
I'm happy with this, in principle. I defer on the kernel innards, but the general engineering looks sound.
Mar 29 2019
Mar 29 2019
Accept with delphi's changes.
Mar 22 2019
Mar 22 2019
OK. I like these diffs even better.
Mar 21 2019
Mar 21 2019
You need the security officer's say-so. I have a personal wavier when I do such commits myself (as I wrote the main random device), but this is non-transferrable, as far as I know.
Mar 7 2019
Mar 7 2019
Very good!
Mar 6 2019
Mar 6 2019
Nice work! Out for interest, why make the output generator selectable? Why not switch completely to Chacha20?
Mar 1 2019
Mar 1 2019
Overcome By Events.
I like this!
OK.
Looks good to me.
Nov 26 2018
Nov 26 2018
markm committed rS341002: Add dependency to allow if_muge device to be only ethernet device in stripped….
Add dependency to allow if_muge device to be only ethernet device in stripped…
Sep 20 2018
Sep 20 2018
Sep 14 2018
Sep 14 2018
Sep 7 2018
Sep 7 2018
Sep 6 2018
Sep 6 2018
Sep 2 2018
Sep 2 2018
Update to the key that I use.
Sep 1 2018
Sep 1 2018
Aug 29 2018
Aug 29 2018
If it doesn't crash anything, then fine! I had stack problems at some point.
markm added inline comments to D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Aug 26 2018
Aug 26 2018
Remove the Yarrow PRNG algorithm option in accordance with due notice
Commit r338324 closes this.
Aug 25 2018
Aug 25 2018
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Sigh. I think I have all cem@'s review comments done now.
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Rebase to top of HEAD.
markm added a comment to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Address cmem@'s review comments.
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Adress some review concerns from cem@, and a few of my own while I'm here.
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Fix documentation nit.
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Add the "differential update" URI to the commit message.
Correct sys/conf/NOTES comment.
markm added inline comments to rS338239: Add a special note to UPDATING for the devmatch stuff. While tested,.
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
markm updated the summary of D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 24 2018
Aug 24 2018
markm added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
In D16873#359829, @jmg wrote:@delphij this is my comment copied over from https://reviews.freebsd.org/D16866?id=47165 that was unaddressed.
Limit the amount of "fast" entropy. We don't need nearly as much
Fix braino of mine where the reseeds would happen far too often,
Aug 23 2018
Aug 23 2018
Thanks folks! Tinderbox build going, then I'll commit.
markm added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Thanks folks! Tinderbox build going, then I'll commit.
markm added inline comments to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
markm updated the diff for D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Address review commnts from delphij.
markm added inline comments to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Apologies to delphij for abandoning the previous identical-looking commit. I was making a pig's ear of the archanist work.
markm added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
This improves things drastically from what they were. More detailed work will follow.
markm retitled D16866: Fix excessive reseeding in random(4). from Fix performance-damaging issues in random(4) to Fix excessive reseeding in random(4)..
Split into two separate commits as per review request.
Add the differential revision to the commit message.
Aug 19 2018
Aug 19 2018
There were a couple of changes which are largely cosmetic to do with #if logic. Change if you want, otherwise LGTM.
My "LGTM" assumes requested changes are taken.
Aug 2 2018
Aug 2 2018
Looks good to me!
Apr 19 2018
Apr 19 2018
Remove empty dir no longer required.
Nov 17 2017
Nov 17 2017
I'm happy with this.
Sep 8 2017
Sep 8 2017
(from hospital bed)
(From hospital bed)
Sep 4 2017
Sep 4 2017
I will be able to help in a week or two when I get out of hospital - I'm about to have an operation.
Aug 28 2017
Aug 28 2017
That might be an idea. The actual PPS rate could be unable, as optimal choices may not be universal. I'm leery of turning off harvesting altogether as that would be a big POLA violation, but lessening the impact makes sense.
Do you mean not harvesting the packet contents?
Aug 27 2017
Aug 27 2017
I'm having a bit of a problem parsing this; could I please ask you to rephrase?