In D43759#1003618, @diizzy wrote:

Try to look at logs more carefully, -std=gnu++1z is defined during build

Don't delete sysutils/conky-awesome in this commit.

Update to 6.17.0

In D43780#1002469, @diizzy wrote:

Should be split into 3 commits,

• Update
• Removal of port (directory) - With a brief explanation in commit msg why its being removed
• Entry to MOVED

I think I understand what you want. But it should be only two commits:

• update
• removal of fport (directory) and entry to MOVED

I checked the latest removal here: https://cgit.freebsd.org/ports/commit/?id=10d79105a75e12e4d287fdaf5fa1ae14c3faf374 and the removal and entry to MOVED are in single commit.

In D43780#1001769, @diizzy wrote:

Looks good, however since you're removing sysutils/conky-awesome you also need to add an entry in MOVED
Prep that and post a link to that change (create a new phab review) here

In D43882#1001770, @diizzy wrote:

Have you at least build tested so users (ports depending on this one) don't break?

In D43898#1001771, @diizzy wrote:

What about these? (These might be installed if people are using ports and not Poudriere)
https://github.com/hzeller/timg/blob/v1.6.0/CMakeLists.txt#L59
https://github.com/hzeller/timg/blob/v1.6.0/CMakeLists.txt#L64

Uses pkgconfig
Remove unneeded BUILD_DEPENDS
Add WITH_POPPLER, WITH_RSVG to CMAKE_OFF.

Update compiler argument. Is this right now?

DIST_SUBDIR
LICENSE_FILE
Fix man directory.
CMAKE helpers.

Remove sysutils/conky-awesome.

In same days will be released a new version: https://lalescu.ro/liviu/fet/forum/index.php?topic=5840.msg32213#msg32213
Waiting for it.

Download manpage instead of generate.
Added FLAVORS.
Remove tar:bzip2 USES.
Remove options which don't have additional dependency.

Commit message:

Commit message:

The planned commit message:

In D43684#996684, @bofh wrote:

In D43684#996681, @uzsolt wrote:

In D43684#996362, @bofh wrote:

Although not mandatory for R-cran ports but ports which are based on c/c++ make sure to test them on 14 Release too as they are based on different llvm version.

The poudriere builds fine on 14.0 too.

As mentioned this is not required for R-cran ports. Only ports which are based on C/C++ sources.

PORTVERSION -> DISTVERSION

In D43684#996375, @bofh wrote:

You don't need to submit commit meta datas here as those are removed by Phabricator so either way we cannot see them. Just make sure you add them while committing.

In D43684#996362, @bofh wrote:

Although not mandatory for R-cran ports but ports which are based on c/c++ make sure to test them on 14 Release too as they are based on different llvm version.

Add review number.

Move to the ports.git

Add D43662 to commit message.

In D43661#995835, @bofh wrote:

For now I am accepting this but next time please do the following and also mention the outcome:

• portclippy Makefile
• portlint -abct
• portfmt Makefile
• poudriere testport

You don't need to show us the results but you should test them and mention in the summary the results.

Fix date

In D23908#570003, @rigoletto wrote:

I think this is fine now. @uzsolt_uzsolt.hu is this good for you?

Thanks!

In D23908#565903, @rigoletto wrote:

In D23908#565842, @uzsolt_uzsolt.hu wrote:

In D23908#565841, @rigoletto wrote:

@uzsolt_uzsolt.hu are you fine with it?

Sorry for late.
Why did you remove own mirror sites? Sometimes the pwmt.org is unavailable. If the source files (zathura-pdf-mupdf) are different I can update it on my host.

The distfiles were not matching and when the upstream mirror is not available the port system grab from the copy in FreeBSD own infrastructure.

Some version ago I could fetch the source, created a bug report (update report) but the committer couldn't fetch it: see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216067

In D23908#565841, @rigoletto wrote:

@uzsolt_uzsolt.hu are you fine with it?

In D23908#525724, @rigoletto wrote:

While working in some of the zathura-* ports the source files were missing (I can't recall which ones now) and that is why I discovered they moved to a GitLab instance. Then I assumed they will move completely at some point, and IMO this is a better idea to keep MASTER_SITES consistent among all zathura-* instead of be changing one by one when necessary.

I think would the best to use multiple MASTER_SITES.

In D16623#501498, @tcberner wrote:

Could you rebase the patch against the current tree?

Sorry but I don't have time to do it. Maybe in some weeks. Sorry again.

In D16623#486717, @tcberner wrote:

What's the state on Uses/tex.mk -- I would be willing to look into that if no one else has already done it :)

I totally forget it :(

In D16623#461841, @mat wrote:

Please, convert bsd.tex.mk to a USES=tex.

In D16623#459817, @arrowd wrote:

Just out of curiosity, what's the rationale for this package split?

First, basic functional diff to 2019.

I don't understand the change you made to the pkg-message file. I asked to choose either install or upgrade, looking at this, it is only needed the first time you install the port, so the second bit about upgrade is not required.

I didn't understand why do you want information at upgrade - but I was regardless.

Updated diff.

In D20457#447854, @mmokhi wrote:

Have you tested it in a clean-env (like poudriere/jail), and it builds?

Yes, poudriere builds fine.

In D19301#413319, @tcberner wrote:

Looks good to me.
If the two maintainers are happy with it too, go for it.

Can you view pdf files with zathura?

In D16623#356521, @mat wrote:

In D16623#353289, @uzsolt_uzsolt.hu wrote:

There are all new ports and no ports removed.

So, how is this an "update" if there are only new things, and no old things go away?

Remove /usr/local... prefix.

In D16623#353271, @mat wrote:

Could you actually provide a diff against the current ports tree? Or are all of those new ports, in that case, the patch is missing the previous ports that are being removed by this update.

Also, the diff could probably loose the /usr/local/poudriere/ports/head/.