Differential D43780
sysutils/conky: take maintainership Authored by uzsolt on Feb 7 2024, 11:36 AM. Tags None Referenced Files
Subscribers None
Details Take sysutils/conky's maintainership.
Portlint reports warnings about USE_LDCONFIG and NLS knobs. Should I do something about it? Ideas: remove some options. I think should remove those option who doesn't implies additional dependency (IPV6, MOC, MPD). What do you think?
Diff Detail
Event TimelineComment Actions
This is alright.
USE_LDCONFIG is definitely worth looking. And testing again by adding it. My knowledge on X related ports is a little bit rusty and @diizzy has more knowledge on these sort of ports. So also consider what he says regarding these.
In most cases if you use portfmt Makefile it's properly handled.
As mentioned in the inline code you have to readd this. However for better choices I would say if you can change it to FLAVORS.
I think a long time ago we have only decided to remove IPV6 option and make it as default. So you can remove the IPV6 OPTIONS and add -DBUILD_IPV6=true to CMAKE_ARGS. Also do not forget to BUMP PORTREVISION when you are mainly adding LICENSE or also changing DEFAULT OPTIONS. If the port is not bumped the LICENSE file will not go in the pkg manifest.
Comment Actions USES= tar:bzip2 in Makefile is incorrect Manpage seems to be available here https://github.com/brndnmtthws/conky/releases/tag/v1.19.6 so you might want to consider using that instead of pulling in pandoc and friends. I agree on enabling options that do not pull in dependencies and do not cause runtime issues, less options is better The X stuff looks fine having a quick glance at it
Comment Actions Download manpage instead of generate. Portlint, portclippy, portfmt are ok.
Comment Actions Looks good, however since you're removing sysutils/conky-awesome you also need to add an entry in MOVED Comment Actions If I understand correctly: in this commit shouldn't contain removing of conky-awesome. After push this commit should I create a new review which contains only removing conky-awesome and an entry in MOVED. Right?
Comment Actions Should be split into 3 commits,
Portlint get it right most of the time, people are still going to read and review the code so if we can improve "readability" without any major changes I'm going to argue that it's more beneficial than keeping portlint happy just for the sake of it. Comment Actions I think I understand what you want. But it should be only two commits:
I checked the latest removal here: https://cgit.freebsd.org/ports/commit/?id=10d79105a75e12e4d287fdaf5fa1ae14c3faf374 and the removal and entry to MOVED are in single commit.
Okay. So:
Comment Actions Now you need to prep a patch for removing conky-awesone Comment Actions I think these two things should be done in one go. The problem is on this commit we are removing SLAVEDIR so when we commit this bulk build will fail as conky-awesome can no longer refer to the MASTERDIR and also there will be a conflict in pkg name. So it's better to do it in one go. Normally all the slave to flavor is done in one go. @uzsolt Please add those in the patches too. I know this has been a long one. But it will really give you a good understanding on how things work. Also while committing you will need to make sure that you have Approved by: portmgr otherwise you cannot commit flavours. Comment Actions @uzsolt Just to give you some more context on why this will fail when you have both the ports try to run: # make -C sysutils/conky -v PKGNAME # make -C sysutils/conky -v PKGNAME FLAVOR=awesome # make -C sysutils/conky-awesome -v PKGNAME From my experience the last two commands will have the same thing with difference in version numbers. We cannot have two ports with same PKGNAME. These are something which is often not identifiable by most of the ports developers as noone builds the entire ports tree. This is more often found by the pkgmgr or the clusteradmins. But when in doubt about such things you can quickly run: poudriere bulk -j <JAIL> -p <PORTS> -a -n This will grab the errors for you. Check at your end when you have both the ports and whether if it throws any error. Comment Actions
I see :(
Comment Actions In the comment section there is a drop down menu called "Add action". If you click it there should be an option like "Abandon". Select it and submit it. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||