Page MenuHomeFreeBSD
Differential D43881

x11-wm/herbstluftwm: remove bashizm
Needs ReviewPublic
Actions

Authored by uzsolt on Feb 14 2024, 4:55 PM.
Tags
None
Referenced Files
F119920320: D43881.id134309.diff
Fri, Jun 13, 11:02 AM
Unknown Object (File)
Thu, Jun 12, 11:01 AM
Unknown Object (File)
Mon, Jun 9, 6:10 PM
Unknown Object (File)
Fri, May 30, 9:13 PM
Unknown Object (File)
Mon, May 19, 1:02 PM
Unknown Object (File)
Sun, May 18, 7:52 AM
Unknown Object (File)
Fri, May 16, 3:47 PM
Unknown Object (File)
Mar 20 2025, 4:46 PM
View All 43 Files
Subscribers
None

Details

Reviewers
bofh
diizzy
Summary

The bashizm removed from autostart file (see https://reviews.freebsd.org/D20457 and https://reviews.freebsd.org/D20004) but the shebang line wasn't fixed.

Portlint, portfmt and portclippy are fine (needed some small fixes).
Poudriere testports are fine on amd64 13.2 and 14.0.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

uzsolt requested review of this revision.Feb 14 2024, 4:55 PM
uzsolt created this revision.
diizzy added inline comments.Feb 25 2024, 12:59 PM
x11-wm/herbstluftwm/Makefile
13

Fix this while at it, += --> =

26

Fix this while at it, += --> =

29

Please have a look if you can fix this properly upstream or possibly use shebangfix instead

x11-wm/herbstluftwm/files/patch-share_autostart
5

Upstreamed?

uzsolt updated this revision to Diff 134980.Feb 25 2024, 3:26 PM

Fixes.

bofh added a comment.Mar 2 2024, 10:52 AM

My knowledge on the x11 stuff is a bit rusty so I will refrain from reviewing this.

Revision Contents
Changeset List

PathSize
x11-wm/
herbstluftwm/
14 lines
files/
18 lines
3 lines

Diff 134980

View Options

x11-wm/herbstluftwm/Makefile

Loading...
View Options

x11-wm/herbstluftwm/files/patch-share_autostart

Loading...
View Options

x11-wm/herbstluftwm/files/pkg-message.in

Loading...