update x11-wm/herbstluftwm 0.7.2
ClosedPublic
Actions

Authored by uzsolt on May 29 2019, 9:08 AM.

Details

Reviewers: None
Commits: rP511822: x11-wm/herbstluftwm: Update to 0.7.2

Summary

up to 0.7.2
remove gettext-runtime, added gnome to USES
patch share/autostart: remove bashism so doesn't need shells/bash
pkg-message.in about bash dependency of scripts

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

uzsolt created this revision.May 29 2019, 9:08 AM

Thanks @uzsolt_uzsolt.hu 😊
Have you tested it in a clean-env (like poudriere/jail), and it builds?

Asking to ensure if you prefer if I run it for a test too?
👍

Makefile
25 ↗	(On Diff #58032)	No examples anymore? 🤔 It means the port is not gonna provide example scripts for initial setup anymore?
pkg-plist
18 ↗	(On Diff #58032)	Will the `%%EXAMPLESDIR%%` be valid while you disabled `EXAMPLES` option? I haven't tested it myself, have you?

mat added a subscriber: mat.Jun 22 2019, 8:16 AM

mat added inline comments.

files/pkg-message.in
1–8 ↗	(On Diff #58032)	Please limit this to installation or upgrade from before some version. See https://www.freebsd.org/doc/en/books/porters-handbook/pkg-files.html (also, remove the `***` lines)
pkg-plist
18 ↗	(On Diff #58032)	`EXAMPLESDIR` is valid, yes, but if you install examples, they MUST be guarded by an `EXAMPLES` option.

In D20457#447854, @mmokhi wrote:

Have you tested it in a clean-env (like poudriere/jail), and it builds?

Yes, poudriere builds fine.

uzsolt updated this revision to Diff 58944.Jun 24 2019, 8:41 AM

uzsolt edited the summary of this revision. (Show Details)

Hi,

I don't understand the change you made to the pkg-message file. I asked to choose either install or upgrade, looking at this, it is only needed the first time you install the port, so the second bit about upgrade is not required.

Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

linimon retitled this revision from x11-wm/herbstluftwm 0.7.2 to update x11-wm/herbstluftwm 0.7.2.Jun 27 2019, 1:34 AM

Updated diff.

I don't understand the change you made to the pkg-message file. I asked to choose either install or upgrade, looking at this, it is only needed the first time you install the port, so the second bit about upgrade is not required.

I didn't understand why do you want information at upgrade - but I was regardless.