Page MenuHomeFreeBSD

devel/R-cran-later: update to 1.3.2
ClosedPublic

Authored by uzsolt on Jan 31 2024, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 9:55 AM
Unknown Object (File)
Sep 10 2024, 6:33 AM
Unknown Object (File)
Sep 8 2024, 11:58 AM
Unknown Object (File)
Jul 5 2024, 12:26 AM
Unknown Object (File)
Jul 4 2024, 7:23 AM
Unknown Object (File)
Jul 2 2024, 9:39 PM
Unknown Object (File)
Jul 2 2024, 9:14 PM
Unknown Object (File)
Jul 2 2024, 8:33 PM
Subscribers
None

Details

Summary

Update to 1.3.2.

Portlint, portclippy, portfmt passed.
Poudriere on 13.2-amd64 passed.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

uzsolt created this revision.

Although not mandatory for R-cran ports but ports which are based on c/c++ make sure to test them on 14 Release too as they are based on different llvm version.

This revision is now accepted and ready to land.Jan 31 2024, 7:20 PM
This revision now requires review to proceed.Jan 31 2024, 7:22 PM

You don't need to submit commit meta datas here as those are removed by Phabricator so either way we cannot see them. Just make sure you add them while committing.

This revision is now accepted and ready to land.Jan 31 2024, 7:24 PM

While not mandatory I'd recommend that you try to move over to DISTVERSION to follow Porters Handbook whenever possible.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions

What you can do regarding commit meta data however is to encapsulate it as a codeblock in Phabricator.

In D43684#996362, @bofh wrote:

Although not mandatory for R-cran ports but ports which are based on c/c++ make sure to test them on 14 Release too as they are based on different llvm version.

The poudriere builds fine on 14.0 too.

In D43684#996375, @bofh wrote:

You don't need to submit commit meta datas here as those are removed by Phabricator so either way we cannot see them. Just make sure you add them while committing.

Oh, understand :) I thought can see them (only I don't find :) ). And I wanted ask how can I include the review number into the uploaded diff file when I don't know the number. So it's irrelevant :)

In D43684#996362, @bofh wrote:

Although not mandatory for R-cran ports but ports which are based on c/c++ make sure to test them on 14 Release too as they are based on different llvm version.

The poudriere builds fine on 14.0 too.

As mentioned this is not required for R-cran ports. Only ports which are based on C/C++ sources.

PORTVERSION -> DISTVERSION

This revision now requires review to proceed.Feb 1 2024, 6:51 PM
In D43684#996684, @bofh wrote:
In D43684#996362, @bofh wrote:

Although not mandatory for R-cran ports but ports which are based on c/c++ make sure to test them on 14 Release too as they are based on different llvm version.

The poudriere builds fine on 14.0 too.

As mentioned this is not required for R-cran ports. Only ports which are based on C/C++ sources.

In the src/ subdirectory there are many cpp files.

LGTM otherwise

devel/R-cran-later/Makefile
4

There too :-)

The planned commit message:

devel/R-cran-later: update to 1.3.2

Use DISTVERSION.
ChangeLog: https://cran.r-project.org/web/packages/later/news/news.html

PR: 275702
Approved by: ...
Differential Revision: https://reviews.freebsd.org/D43684

This revision is now accepted and ready to land.Feb 20 2024, 7:13 PM
This revision was automatically updated to reflect the committed changes.
uzsolt marked an inline comment as done.