Page MenuHomeFreeBSD

graphics/zathura: Update to 4.3
ClosedPublic

Authored by rigoletto on Feb 23 2019, 1:07 AM.

Details

Summary

PR 235952 233727 229935 232902 233021

  • update graphics/zathura to 4.3
  • update graphics/mupdf to 1.14.0
  • update graphics/zathura-pdf-mupdf to 0.3.4

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rigoletto created this revision.Feb 23 2019, 1:07 AM
rigoletto updated this revision to Diff 54241.Feb 23 2019, 1:39 AM

Cleaning.

rigoletto edited the summary of this revision. (Show Details)Feb 23 2019, 2:01 AM
rigoletto added a reviewer: uzsolt_uzsolt.hu.
tcberner added inline comments.Feb 23 2019, 8:22 AM
graphics/mupdf/Makefile
6 ↗(On Diff #54241)

^ DISTVERSIONPREFIX comes before DISTVERSION

22 ↗(On Diff #54241)

^ that should be handled by USES=jpeg.

graphics/zathura-pdf-mupdf/Makefile
30 ↗(On Diff #54241)

^ why +=?

rigoletto updated this revision to Diff 54256.Feb 23 2019, 2:51 PM
rigoletto marked 3 inline comments as done.

Fixing.

  • remove jpeg-turbo from BUILD_DEPENDS in graphics/mupdf
  • remove + from MESON_ARGS in zathura-pdf-mupdf

Thanks.

Can you view pdf files with zathura?

rigoletto added a comment.EditedFeb 23 2019, 3:55 PM

Can you view pdf files with zathura?

I usually use just mupdf, but yes they are opening using zathura-pdf-mupdf.

↓ Why is this showing up in here? ↓

graphics/mupdf/Makefile
6 ↗(On Diff #54241)

But that is DISTVERSIONSUFFIX. :-D

rigoletto updated this revision to Diff 54257.Feb 23 2019, 3:56 PM

Remove gmake from graphics/zathura-pdf-mupdf. Not needed.

tcberner accepted this revision.Feb 23 2019, 5:54 PM

Looks good to me.
If the two maintainers are happy with it too, go for it.

This revision is now accepted and ready to land.Feb 23 2019, 5:54 PM
tcberner requested changes to this revision.Feb 23 2019, 5:55 PM

ah wait, was removing the NLS optiona intentional? :D

This revision now requires changes to proceed.Feb 23 2019, 5:55 PM

Looks good to me.
If the two maintainers are happy with it too, go for it.

If zathura works with mupdf plugin (now I can't test it) for me it's okay.

rigoletto added a comment.EditedFeb 23 2019, 6:30 PM

ah wait, was removing the NLS optiona intentional? :D

Yes, there is no option to actually disable it. The option was no-op. :-)

Looks good to me.
If the two maintainers are happy with it too, go for it.

If zathura works with mupdf plugin (now I can't test it) for me it's okay.

Is it broken with some other plugin?

tcberner accepted this revision.Feb 23 2019, 10:43 PM

ok, in that case it looks fine to me again :D

This revision is now accepted and ready to land.Feb 23 2019, 10:43 PM
This revision was automatically updated to reflect the committed changes.