Page MenuHomeFreeBSD

deskutils/fet: update to 6.18.1
ClosedPublic

Authored by uzsolt on Feb 6 2024, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 3:18 AM
Unknown Object (File)
Sun, Apr 14, 10:54 PM
Unknown Object (File)
Sun, Apr 14, 5:37 PM
Unknown Object (File)
Tue, Apr 9, 2:54 AM
Unknown Object (File)
Mon, Apr 8, 10:33 PM
Unknown Object (File)
Sun, Apr 7, 6:02 PM
Unknown Object (File)
Tue, Apr 2, 11:08 PM
Unknown Object (File)
Sat, Mar 30, 12:39 AM
Subscribers
None

Details

Summary

Simple update to 6.17.0.

Testport is fine on 13.2 and 14.0 too (qt5 and qt6 flavors too).
Portfmt, portclippy and portlint checks are ok.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

uzsolt requested review of this revision.Feb 6 2024, 6:09 AM
uzsolt created this revision.
uzsolt retitled this revision from deskutils/fet: update to 6.16.0 to deskutils/fet: update to 6.17.0.
uzsolt edited the summary of this revision. (Show Details)

Update to 6.17.0

diizzy requested changes to this revision.EditedFeb 20 2024, 7:54 PM

Try to look at logs more carefully, -std=gnu++1z is defined during build

This revision now requires changes to proceed.Feb 20 2024, 7:54 PM

Try to look at logs more carefully, -std=gnu++1z is defined during build

Thanks.
What should I add to compiler USES?
I found on https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html :

‘gnu++17’
‘gnu++1z’

GNU dialect of -std=c++17. This is the default for C++ code. The name ‘gnu++1z’ is deprecated.

Is the c++17-lang option is enough? I see in Mk/Uses/compiler.mk the gnu++17 in a for loop (https://cgit.freebsd.org/ports/tree/Mk/Uses/compiler.mk#n139) and sets the OUTPUT_gnu++17 to yes if the CC accepts. Should I check this value?

Hi,

Adding c++17-lang will be "good enough"

Best regards,
Daniel

Fix compiler standard.
New release: 6.18.0

Poudriere testport on amd64 13.2, 14.0 are ok (both qt5 and qt6). Portfmt, portclippy, portlint are ok.

Only one note: on flavor qt6 I see a warning message:
Warning: you might not need LIB_DEPENDS on libGL.so
But on flavor qt5 this message doesn't appear.

uzsolt retitled this revision from deskutils/fet: update to 6.17.0 to deskutils/fet: update to 6.18.0.Feb 24 2024, 5:50 AM

Only one note: on flavor qt6 I see a warning message:
Warning: you might not need LIB_DEPENDS on libGL.so
But on flavor qt5 this message doesn't appear.

poudriere's LIB checking is not too good. Sometimes it gives these sort of errors/warnings. If in doubts run the poudriere testport with -i which will give you an interactive jail after the test finishes. Recheck with ldd whether if the library is linked or not.

Update to 6.18.1.
Portlint, portclippy, portfmt are ok.
Poudriere testport passed on amd64 13.2 and 14.0, both qt5 and qt6 flavors.

Sorry I didn't notice the accept flag only now. This review is in "Waiting on Review" (not "Ready to Review").

uzsolt retitled this revision from deskutils/fet: update to 6.18.0 to deskutils/fet: update to 6.18.1.Mar 3 2024, 7:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2024, 1:27 PM
This revision was automatically updated to reflect the committed changes.