In D19495#449190, @rgrimes wrote:In D19495#449173, @darius.mihaim_gmail.com wrote:I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.
Please delay the #ifdef guards, as per the discussion in the 2019/06/20 bhyve call we may of found an alternative, using a project branch and rebasing the git to that.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 26 2019
Jun 26 2019
May 8 2018
May 8 2018
In D10213#323447, @mmacy wrote:@mihai Before this can proceed this review needs to be broken up in to at _least_ 3 pieces
- MI/MD refactoring of sys/amd64/vmm - you need to identify all the common interfaces that are shared and move them out of amd64, this means you need to define a clean shared API where possible, e.g. starting / stopping guest / setting nvcpus / etc
- MI/MD refactoring of libvmmapi
We tried to do this before, but we analyzed the interfaces, we saw that they are x86 dependent (memseg set, etc). We would end up with a common interface only for starting/stopping/running.
Feb 26 2018
Feb 26 2018
We don't have any implementation for them in arm and most of them have some x86 specific bits (like registers). This is why we choose to only make what we have machine independent. And when new features appear for ARM we would take care to make them as general as possible (e.g. virtio.c -> which is WIP)
Feb 25 2018
Feb 25 2018
Can you extend what means MD/MI?
Feb 23 2018
Feb 23 2018
Any update on this?
Any update on this?
mihai added a comment to D11848: Add timer virtualization specific bits as a prerequisite for bhyvearm.
Any update on this?
Aug 14 2017
Aug 14 2017
Alex Ivan update the diff using Andrew recommendations (parent or maintenance entry)
mihai updated the diff for D11848: Add timer virtualization specific bits as a prerequisite for bhyvearm.
Updated with more context.
Aug 9 2017
Aug 9 2017
mihai updated the diff for D11846: Add to sysreg definition for coproc regs required for virtualization.
Add HMAIR registers.
Aug 7 2017
Aug 7 2017
- modified cast
- fix tab/spaces
Aug 4 2017
Aug 4 2017
mihai updated the diff for D11846: Add to sysreg definition for coproc regs required for virtualization.
Ordered entries. If they are not order, please provide the methodology of ordering them.
mihai added inline comments to D11846: Add to sysreg definition for coproc regs required for virtualization.
mihai added inline comments to D11846: Add to sysreg definition for coproc regs required for virtualization.
Aug 3 2017
Aug 3 2017
Can we commit this?
I've created three new patches containing:
- sysreg bits
- generic_timer bits
- gic bits.
Jul 22 2017
Jul 22 2017
This new version of the patch fixes comments from Andrew Turner and Peter Grehan:
- create platform dependent code for bhyve (no more bhyvearm/libvmmapiarm duplicate directory)
- create a device for the vgic in order to user the getter methods from the gic device
- added timer virtualization
- completed vGIC virtualization
Apr 13 2017
Apr 13 2017
Apr 11 2017
Apr 11 2017
I've put some questions into the comments. As soon as I get answers to those, I will solve them and UPDATE the commit diff.
Mar 31 2017
Mar 31 2017
I'm ok with commiting it.
Mar 22 2017
Mar 22 2017
The comment "/* Leave HYP mode */" isn't consistent. We are checking if we are in HypMode only.
Mar 21 2017
Mar 21 2017
Uploaded a file instead of copy/paste.
Mar 20 2017
Mar 20 2017
Update the diff acording to the last review.
Mar 19 2017
Mar 19 2017
I've applied all the recomandations from Andrew, besides the "struct arm_boot_params *" one.
Mar 18 2017
Mar 18 2017
Forgot to add the new file sys/arm/arm/hypervisor-stub.S