Page MenuHomeFreeBSD
Differential D11846

Add to sysreg definition for coproc regs required for virtualization
ClosedPublic
Actions

Authored by mihai on Aug 3 2017, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 4:05 PM
Unknown Object (File)
Fri, Nov 15, 5:11 AM
Unknown Object (File)
Nov 2 2024, 10:39 PM
Unknown Object (File)
Oct 26 2024, 6:38 AM
Unknown Object (File)
Oct 12 2024, 11:50 PM
Unknown Object (File)
Sep 30 2024, 9:58 AM
Unknown Object (File)
Sep 27 2024, 5:53 AM
Unknown Object (File)
Sep 26 2024, 8:08 PM
View All 79 Files
Subscribers
alexandru.elisei_gmail.com
alexnivan_gmail.com
darius.mihaim_gmail.com
emaste
grehan
imp
mmel

Details

Reviewers
andrew
grehan
mmel
Group Reviewers
ARM
Commits
rS326850: Add the virtualisation special register definitions.
Summary

Add to sysreg definition for coproc regs required for virtualization

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mihai created this revision.Aug 3 2017, 3:00 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 3 2017, 3:00 PM
emaste mentioned this in D10213: Adding virtualization support for ARMv7 platforms.Aug 3 2017, 3:07 PM
emaste added a subscriber: emaste.Aug 3 2017, 3:10 PM

In the future can you please include full context (details on https://wiki.freebsd.org/Phabricator) e.g.

git diff -U999999 other-branch
svn diff --diff-cmd=diff -x -U999999
andrew accepted this revision.Aug 3 2017, 5:17 PM

This looks good. I'm assuming the registers are correct.

This revision is now accepted and ready to land.Aug 3 2017, 5:17 PM
grehan accepted this revision.Aug 3 2017, 6:15 PM

I checked the numbers and they look good.

mmel added a subscriber: mmel.Aug 4 2017, 5:21 AM
mmel added inline comments.
sys/arm/include/sysreg.h
86 ↗(On Diff #31529)

Please, keep the list sorted - here and below.
And yes, the whole hyp. related block is misordered - It should be at the end of C0 section.

323 ↗(On Diff #31529)

I'm only curious here - why a '2' suffix and do you really need LPAE version of TTBR registers?

mihai added inline comments.Aug 4 2017, 6:42 AM
sys/arm/include/sysreg.h
323 ↗(On Diff #31529)

On hyp-mode LPAE is the only supported page table format.

mihai added inline comments.Aug 4 2017, 6:48 AM
sys/arm/include/sysreg.h
323 ↗(On Diff #31529)

It's 2 because is the 64bit version (2 registers). CP15_TTBR0/1 already exists for 32bits. I would have the same name. Please provide another naming convention if this is not ok.

mihai updated this revision to Diff 31598.Aug 4 2017, 7:54 PM
mihai edited edge metadata.

Ordered entries. If they are not order, please provide the methodology of ordering them.

This revision now requires review to proceed.Aug 4 2017, 7:54 PM
mihai updated this revision to Diff 31818.Aug 9 2017, 3:20 PM

Add HMAIR registers.

mmel accepted this revision.Aug 11 2017, 11:23 AM
mmel added inline comments.
sys/arm/include/sysreg.h
323 ↗(On Diff #31818)

Rather, I would prefer <foo>_LPAE or something like. But this is only my "soft" personal preference.

This revision is now accepted and ready to land.Aug 11 2017, 11:23 AM
Closed by commit rS326850: Add the virtualisation special register definitions. (authored by andrew). · Explain WhyDec 14 2017, 1:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
include/
35 lines

Diff 36587

View Options

head/sys/arm/include/sysreg.h

Loading...