Page MenuHomeFreeBSD

mihai (Mihai Carabas)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2016, 4:55 PM (190 w, 2 d)

Recent Activity

Jun 26 2019

mihai added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Please delay the #ifdef guards, as per the discussion in the 2019/06/20 bhyve call we may of found an alternative, using a project branch and rebasing the git to that.

Jun 26 2019, 12:39 PM · bhyve

May 8 2018

mihai added a comment to D10213: Adding virtualization support for ARMv7 platforms.

@mihai Before this can proceed this review needs to be broken up in to at _least_ 3 pieces

    1. MI/MD refactoring of sys/amd64/vmm - you need to identify all the common interfaces that are shared and move them out of amd64, this means you need to define a clean shared API where possible, e.g. starting / stopping guest / setting nvcpus / etc
  1. MI/MD refactoring of libvmmapi

We tried to do this before, but we analyzed the interfaces, we saw that they are x86 dependent (memseg set, etc). We would end up with a common interface only for starting/stopping/running.

May 8 2018, 8:42 AM · ARM

Feb 26 2018

mihai added a comment to D10213: Adding virtualization support for ARMv7 platforms.

We don't have any implementation for them in arm and most of them have some x86 specific bits (like registers). This is why we choose to only make what we have machine independent. And when new features appear for ARM we would take care to make them as general as possible (e.g. virtio.c -> which is WIP)

Feb 26 2018, 8:24 AM · ARM

Feb 25 2018

mihai added a comment to D10213: Adding virtualization support for ARMv7 platforms.

Can you extend what means MD/MI?

Feb 25 2018, 11:36 AM · ARM

Feb 23 2018

mihai added a comment to D10213: Adding virtualization support for ARMv7 platforms.

Any update on this?

Feb 23 2018, 9:15 AM · ARM
mihai added a comment to D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.

Any update on this?

Feb 23 2018, 9:15 AM
mihai added a comment to D11848: Add timer virtualization specific bits as a prerequisite for bhyvearm.

Any update on this?

Feb 23 2018, 9:14 AM

Aug 14 2017

mihai updated the diff for D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.

Alex Ivan update the diff using Andrew recommendations (parent or maintenance entry)

Aug 14 2017, 1:48 PM
mihai updated the diff for D11848: Add timer virtualization specific bits as a prerequisite for bhyvearm.

Updated with more context.

Aug 14 2017, 10:23 AM

Aug 9 2017

mihai updated the diff for D11846: Add to sysreg definition for coproc regs required for virtualization.

Add HMAIR registers.

Aug 9 2017, 3:20 PM

Aug 7 2017

mihai added inline comments to D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.
Aug 7 2017, 3:40 PM
mihai updated the diff for D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.
  • modified cast
  • fix tab/spaces
Aug 7 2017, 1:27 PM

Aug 4 2017

mihai updated the diff for D11846: Add to sysreg definition for coproc regs required for virtualization.

Ordered entries. If they are not order, please provide the methodology of ordering them.

Aug 4 2017, 7:54 PM
mihai added inline comments to D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.
Aug 4 2017, 8:15 AM
mihai added inline comments to D11846: Add to sysreg definition for coproc regs required for virtualization.
Aug 4 2017, 6:48 AM
mihai added inline comments to D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.
Aug 4 2017, 6:45 AM
mihai added inline comments to D11846: Add to sysreg definition for coproc regs required for virtualization.
Aug 4 2017, 6:42 AM

Aug 3 2017

mihai added a comment to D10094: arm: Move the code to exit hyp to hypervisor-stub.S.

Can we commit this?

Aug 3 2017, 3:10 PM
mihai added a comment to D10213: Adding virtualization support for ARMv7 platforms.

I've created three new patches containing:

  • sysreg bits
  • generic_timer bits
  • gic bits.
Aug 3 2017, 3:06 PM · ARM
mihai created D11848: Add timer virtualization specific bits as a prerequisite for bhyvearm.
Aug 3 2017, 3:05 PM
mihai created D11847: Add GIC virtualization bits as a prerequisites for bhyvearm.
Aug 3 2017, 3:03 PM
mihai created D11846: Add to sysreg definition for coproc regs required for virtualization.
Aug 3 2017, 3:00 PM

Jul 22 2017

mihai updated the diff for D10213: Adding virtualization support for ARMv7 platforms.

This new version of the patch fixes comments from Andrew Turner and Peter Grehan:

  • create platform dependent code for bhyve (no more bhyvearm/libvmmapiarm duplicate directory)
  • create a device for the vgic in order to user the getter methods from the gic device
  • added timer virtualization
  • completed vGIC virtualization
Jul 22 2017, 7:28 PM · ARM
mihai updated subscribers of D10213: Adding virtualization support for ARMv7 platforms.
Jul 22 2017, 7:21 PM · ARM

Apr 13 2017

mihai added inline comments to D10213: Adding virtualization support for ARMv7 platforms.
Apr 13 2017, 8:31 PM · ARM

Apr 11 2017

mihai added a reviewer for D10213: Adding virtualization support for ARMv7 platforms: grehan.
Apr 11 2017, 6:58 PM · ARM
mihai added a comment to D10213: Adding virtualization support for ARMv7 platforms.

I've put some questions into the comments. As soon as I get answers to those, I will solve them and UPDATE the commit diff.

Apr 11 2017, 6:57 PM · ARM

Mar 31 2017

mihai added a reviewer for D10213: Adding virtualization support for ARMv7 platforms: andrew.
Mar 31 2017, 9:10 AM · ARM
mihai created D10213: Adding virtualization support for ARMv7 platforms.
Mar 31 2017, 9:10 AM · ARM
mihai accepted D10094: arm: Move the code to exit hyp to hypervisor-stub.S.

I'm ok with commiting it.

Mar 31 2017, 8:49 AM

Mar 22 2017

mihai added a comment to D10094: arm: Move the code to exit hyp to hypervisor-stub.S.

The comment "/* Leave HYP mode */" isn't consistent. We are checking if we are in HypMode only.

Mar 22 2017, 2:53 PM

Mar 21 2017

mihai updated the diff for D10045: ARMv7 handle hyp-mode.

Uploaded a file instead of copy/paste.

Mar 21 2017, 8:06 AM · ARM

Mar 20 2017

mihai updated the diff for D10045: ARMv7 handle hyp-mode.

Update the diff acording to the last review.

Mar 20 2017, 12:57 PM · ARM

Mar 19 2017

mihai updated the diff for D10045: ARMv7 handle hyp-mode.

I've applied all the recomandations from Andrew, besides the "struct arm_boot_params *" one.

Mar 19 2017, 12:08 PM · ARM

Mar 18 2017

mihai updated the diff for D10045: ARMv7 handle hyp-mode.

Forgot to add the new file sys/arm/arm/hypervisor-stub.S

Mar 18 2017, 3:41 PM · ARM
mihai created D10045: ARMv7 handle hyp-mode.
Mar 18 2017, 3:34 PM · ARM