- Fix .if to be a proper .elif
- Clarify UPDATING and man pages on option
- Other review findings
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 1 2017
Nov 1 2017
bdrewery updated the summary of D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery updated the diff for D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery added inline comments to D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
bdrewery added a comment to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
In D12840#267370, @emaste wrote:Should we make a reference to WITHOUT_UNIFIED_OBJDIR being a transition aid that will be removed later on? (for 12.0)?
bdrewery added inline comments to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery added a comment to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
In D12840#267376, @sjg wrote:In Junos build we have always used .OBJDIR = ${OBJTOP} for the case ${.CURDIR} == ${SRCTOP} which is why I asserted that it is the correct answer ;-)
bdrewery updated the diff for D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
Review findings
bdrewery added inline comments to D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
bdrewery added inline comments to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
Oct 31 2017
Oct 31 2017
xdev: Follow-up r325087: Need to build lib/clang before lld.
bdrewery updated the test plan for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
kernel-toolchain: Fix improper build order after r325244.
bdrewery updated the test plan for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
bdrewery updated the test plan for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
bdrewery updated the diff for D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
- Fix some release/ scripts to use sys/boot .OBJDIR.
- Revert option_survey change as it really doesn't care where the files are.
bdrewery committed rS325247: Disconnect libpathconv tests since they require external perl and do not work….
Disconnect libpathconv tests since they require external perl and do not work…
bdrewery added inline comments to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
Use -j hw.ncpu for build/install.
build-tools: De-special-case the gcc tools build.
kernel-toolchain: Skip world _obj and _cleanobj phases.
Follow-up r297998: Remove redundant TOOLS_PREFIX in XMAKE.
In D12839#266680, @dim wrote:Hmm, I rather liked the absolute paths that ${.OBJDIR} and ${OBJTOP} introduced. I find relative path output during builds a bit obfuscating. How much performance gain does this change deliver, in exchange for more obscurity?
bdrewery added inline comments to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery updated the diff for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
trap more signals for rmdir cleanup.
This should be final.
bdrewery updated the diff for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Fix 'make print-dir' mistake, add WITHOUT_AUTO_OBJ man file and force "on" for 'make showconfig'.
Also tested that makeman did the right thing and shows AUTO_OBJ as default enabled.
native-xtools: Allow SYSTEM_COMPILER to be used after r325001.
bdrewery updated the diff for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Disable opportunistic AUTO_OBJ for showconfig/print-dir
bdrewery updated the diff for D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
Rebase
This check is not ready here yet.
makeman: Ensure MK_AUTO_OBJ is disabled in some lookups.
AUTO_OBJ can work for crunchgen build-tools.
Disable MK_AUTO_OBJ as a make argument like r325078.
bdrewery updated the diff for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Don't bother trying to enable MK_AUTO_OBJ if WITHOUT_AUTO_OBJ is set or
MK_AUTO_OBJ is in .MAKEOVERRIDES.
cleanworld: No need to cleandir if MK_AUTO_OBJ is enabled.
Fix installworld/distrib-dirs for pathconv after r325186.
Looks good, thanks for doing this. Yes do please update EVENTHANDLER.9
bdrewery updated the summary of D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery updated the diff for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Uploaded the wrong commit, fix that.
bdrewery updated the diff for D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Export MK_AUTO_OBJ==yes finding to sub-makes. This was not being checked
very often in buildworld but exporting the positive finding will save more time.
bdrewery updated subscribers of D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
bdrewery updated subscribers of D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery added inline comments to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery updated the summary of D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery updated subscribers of D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..
bdrewery committed rS325191: Move some objdir handling (OBJROOT/OBJTOP) out of DIRDEPS_BUILD-only files..
Move some objdir handling (OBJROOT/OBJTOP) out of DIRDEPS_BUILD-only files.
Rename RELTOP since it will mean something else globally.
Add RELOBJTOP and RELSRCTOP for relative paths.
DIRDEPS_BUILD: Update dependencies.
DIRDEPS_BUILD: Connect new directories.
Connect libpathconv, disconnected since import in r309035.
Provide clang-rt for the clang toolchain as well.
libdevdctl tests require an external port.
DIRDEPS_BUILD: libgcc now depends on MK_LLVM_LIBUNWIND
Chase r315223: Disconnect ipftest/ipresend
Run mm-mtree with whatever -j value the build is using.
bdrewery committed rS325180: Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler..
Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler.
These values already set by src.libnames.mk.
Use more clear SRCTOP here.
Oct 30 2017
Oct 30 2017
bdrewery added inline comments to D8188: Introduce lib/libgcc_eh and lib/libgcc_s for LLVM's implementation.
bdrewery committed rS325163: Fix native-xtools installion after r325082 and r325000 to be to /nxb-bin..
Fix native-xtools installion after r325082 and r325000 to be to /nxb-bin.
In D12782#266099, @bdrewery wrote:I am going to revert this. I am adding a native-xtools-install and will pass in DESTDIR for it. This case is a bit unclear to me though. Did you intend to have the files installed in DESTDIR/usr/bin/* or DESTDIR/nxb-bin/usr/bin/* ?
bdrewery added a comment to D12817: Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler..
In D12817#266170, @emaste wrote:Is it the case that the other C++11 option in this block (CLANG) works only because it is split into CLANG and CLANG_BOOTSTRAP? It would otherwise have the same problem, yes?
Oct 29 2017
Oct 29 2017
bdrewery committed rS325089: xdev: Consolidate duplicate cross-tools build/install list into XDEVDIRS..
xdev: Consolidate duplicate cross-tools build/install list into XDEVDIRS.
xdev: Fix build for platforms needing LLD.
bdrewery committed rS325088: xdev: Remove excess '/' since XDTP is asserted to be an absolute path..
xdev: Remove excess '/' since XDTP is asserted to be an absolute path.
xdev: Add missing 'make obj' treewalk for 'make includes'.
lib32/libsoft: Store object files in a more consistent structure.
AUTO_OBJ: auto.obj.mk mkdir -p simplification
bdrewery committed rS325082: Change native-xtools to not install by default; add a native-xtools-install..
Change native-xtools to not install by default; add a native-xtools-install.
bdrewery committed rS325083: Suggest TARGET/TARGET_ARCH, XDEV/XDEV_ARCH are depcrecated in r269031..
Suggest TARGET/TARGET_ARCH, XDEV/XDEV_ARCH are depcrecated in r269031.
build(7): Document native-xtools.
Fix xdev TARGET/TARGET_ARCH assertion and expand to native-xtools.
build(7): Document xdev targets.
Disable AUTO_OBJ as a make argument to ensure it really is disabled.
MAKEOBJDIR should be an absolute path, not any path with a slash.
Rework r254951 to not reach into private OBJDIR areas.
Remove comment: debug files can be useful for build tools.
Move some LIBCOMPAT tmpdir logic setup to its own build target.
bdrewery committed rS325073: MK_TESTS is disabled in early phases, no need for TESTBASE extraction here..
MK_TESTS is disabled in early phases, no need for TESTBASE extraction here.
FAST_DEPEND clean hack: Remove lib32/soft files properly.
bdrewery committed rS325071: Move FAST_DEPEND cleanup hack into its own target and call from _cleanobj..
Move FAST_DEPEND cleanup hack into its own target and call from _cleanobj.
bdrewery committed rS325070: We don't need LIB32 directories extracted in early phase legacy/WORLDTMP dirs..
We don't need LIB32 directories extracted in early phase legacy/WORLDTMP dirs.
Move sendmail special check into a _sanity_check target.
Disallow using a colon ':' in source checkout paths.
Oct 28 2017
Oct 28 2017
- Update to 3.0-2584-g2c19d562
I am going to revert this. I am adding a native-xtools-install and will pass in DESTDIR for it. This case is a bit unclear to me though. Did you intend to have the files installed in DESTDIR/usr/bin/* or DESTDIR/nxb-bin/usr/bin/* ?