Can someone summarize what's preventing this patch from being committed?

Can someone summarize what's left or preventing this from being committed?

3.7.1 is already in the tree.

I pasted the wrong diff into the circonus-agent update, disregard the previous revision. The correct revision is now present in this review.

Update Makefile variables per suggestion from @mat

Reorder variables in Makefile per suggestion from @mat

The one thing I would say, however, is I'm looking forward to the metaport that will assume the name of drm-kmod and will do the right thing for users based on their architecture. I know that's next, I'm just stating the obvious for future onlookers.

In D16311#346083, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Thank you @munro_ip9.org !

@eadler :, I understand, and no problem. I think you're hitting on something that would be good to formalize, but I want to make sure that what gets prescribed as a community rule of thumb is accurate and strikes the right balance. I think we'd all collectively take something that's an improvement and incremental over something that is perfect. "Perfect is the enemy of good." :~] Also, if you want to hit me up on Slack or IRC to talk in a higher-bandwidth medium than a review, feel free.

Thank you for carrying this discussion forward into a separate review, @eadler.

Incorporate @swills' feedback. Work around daemon(8)'s lack of syslog functionality in 10-STABLE.

Provide some feedback and suggested some alternate wording.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I keep forgetting you prefer full context patches to review.

I like to be able to review the changes, to review the changes, it is easier to be able to see the whole files.

In D15722#332860, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Full context

No, I sent a note to the maintainer to get approval for this change after submitting the review. I will open a PR in a day or two if I don't hear back from the maintainer.

Agreed, and I have already removed ${LOCALBASE}/bin/go from BUILD_DEPENDS - I wasn't arguing with you, I was only explaining why I added it in the first place. :)

Paste with context

Updated port with feedback from @mat

I want to point out that the lack of code formatting tool like clang-format resulted in @markj spending some of his precious cycles reviewing not the substance of the patch, but instead commenting on style nits (correct according to style(9) - thank you @markj).

Remove unnecessary post-patch step.

Remove the use of :DEFAULT

Updated and addresses all known feedback from @mat .

In D15311#323813, @mat wrote:

You need to bump PORTREVISION.

Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Upgrade gravitational teleport to 2.5.7.

In D15179#320596, @sam_samgwydir.com wrote:

Do you pass portlint -Aac? Also does it build on {10.4, 11.2, CURRENT}-{i386,amd64} with poudriere testport?

Staged diff via svn diff

Updated to 0.13.0

Updated to use a date for DISTVERSION.

@pi /@mat: could you give this another once over based on the feedback and changes above?

Address feedback from @mat and use post-patch instead of pre-patch and do-patch.