Page MenuHomeFreeBSD

[new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components
ClosedPublic

Authored by jmd on Aug 21 2018, 2:32 AM.

Details

Summary

Initial port for a drm-legacy-kmod port. Probably version check should be changed if base drm1/drm2 legacy bits are dropped.

Test Plan

Builds on amd64/HEAD. No hardware old enough to test.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmd created this revision.Aug 21 2018, 2:32 AM
linimon retitled this revision from graphics/drm-legacy-kmod to [new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components.Aug 21 2018, 2:35 AM
jmd updated this revision to Diff 47014.Aug 21 2018, 2:42 AM

Pet portlint.

mat added inline comments.Aug 21 2018, 10:18 AM
graphics/drm-legacy-kmod/Makefile
18 ↗(On Diff #47014)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

jmd updated this revision to Diff 47032.Aug 21 2018, 1:20 PM

Order variables

seanc accepted this revision.Aug 21 2018, 5:40 PM
This revision is now accepted and ready to land.Aug 21 2018, 5:40 PM
zeising accepted this revision.Aug 21 2018, 6:44 PM

Noting further, except what mat@ already pointed out.
Don't forget to update conflicting in the other bsd-*-kmod ports.

seanc added a comment.Aug 21 2018, 6:50 PM

The one thing I would say, however, is I'm looking forward to the metaport that will assume the name of drm-kmod and will do the right thing for users based on their architecture. I know that's next, I'm just stating the obvious for future onlookers.

This revision was automatically updated to reflect the committed changes.