[new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components
ClosedPublic
Actions

Authored by jmd on Aug 21 2018, 2:32 AM.

Details

Reviewers

seanc
zeising

Commits

rP477762: new port: graphics/drm-legacy-kmod

Summary

Initial port for a drm-legacy-kmod port. Probably version check should be changed if base drm1/drm2 legacy bits are dropped.

Test Plan

Builds on amd64/HEAD. No hardware old enough to test.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jmd created this revision.Aug 21 2018, 2:32 AM

Herald added a subscriber: mat. · View Herald TranscriptAug 21 2018, 2:32 AM

linimon retitled this revision from graphics/drm-legacy-kmod to [new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components.Aug 21 2018, 2:35 AM

Pet portlint.

kbowling added a subscriber: kbowling.Aug 21 2018, 3:36 AM

mat added inline comments.Aug 21 2018, 10:18 AM

graphics/drm-legacy-kmod/Makefile
18	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Order variables

seanc accepted this revision.Aug 21 2018, 5:40 PM

This revision is now accepted and ready to land.Aug 21 2018, 5:40 PM

Noting further, except what mat@ already pointed out.
Don't forget to update conflicting in the other bsd-*-kmod ports.

The one thing I would say, however, is I'm looking forward to the metaport that will assume the name of drm-kmod and will do the right thing for users based on their architecture. I know that's next, I'm just stating the obvious for future onlookers.

Closed by commit rP477762: new port: graphics/drm-legacy-kmod (authored by jmd). · Explain WhyAug 22 2018, 12:35 AM

This revision was automatically updated to reflect the committed changes.