Page MenuHomeFreeBSD

munro_ip9.org (Thomas Munro)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2018, 5:16 AM (79 w, 7 h)

Recent Activity

Thu, Oct 3

munro_ip9.org updated the diff for D17166: Add a way to get version information from querylocale(3)..

Sorry for the long delay. Here is a new version that addresses a theoretical problem not handled before: what if our code changes for some reason, but the CLDR version doesn't? So I added an extra part to the version string. Changes:

Thu, Oct 3, 10:45 AM

Oct 8 2018

munro_ip9.org updated the diff for D17461: truss: handle shm_open's special SHM_ANON value better..

Fixes for style feedback from jhb. Thanks!

Oct 8 2018, 8:35 PM

Oct 7 2018

munro_ip9.org created D17461: truss: handle shm_open's special SHM_ANON value better..
Oct 7 2018, 9:53 PM
munro_ip9.org created D17457: Teach truss how to display shm_open(2), shm_unlink(2).
Oct 7 2018, 12:34 PM

Sep 15 2018

munro_ip9.org added inline comments to D17166: Add a way to get version information from querylocale(3)..
Sep 15 2018, 9:26 PM
munro_ip9.org updated the diff for D17166: Add a way to get version information from querylocale(3)..

Instead of introducing a new function querylocaleversion(3), teach the existing querylocale(3) to return versions, as suggested by kib. I think I prefer it this way, but I'm not sure if it's more or less likely to survive contact with the standards process.

Sep 15 2018, 5:01 AM

Sep 14 2018

munro_ip9.org added a comment to D17166: Add a way to get version information from querylocale(3)..
In D17166#366077, @kib wrote:

You could add a bit to the LC_XXX_MASK and make querylocale() returning either string or numeric representation of the version when the bit is set together with the real locale category bit.

Sep 14 2018, 11:28 PM
munro_ip9.org added a comment to D17166: Add a way to get version information from querylocale(3)..

Thank you!

Sep 14 2018, 12:21 PM
munro_ip9.org added inline comments to D17166: Add a way to get version information from querylocale(3)..
Sep 14 2018, 11:53 AM
munro_ip9.org updated the diff for D17166: Add a way to get version information from querylocale(3)..

strncpy->strlcpy, as suggested by yuripv.

Sep 14 2018, 11:50 AM
munro_ip9.org updated the diff for D17166: Add a way to get version information from querylocale(3)..

Adjust man pages based on feedback from 0mp. While removing "All rights reserved", and after checking some nearby files and the documentation, it seemed that the thing to do with new files was to use my own name on the copyright message. I also added a new line to the querylocaleversion.3 page to mention the purpose of the version string.

Sep 14 2018, 9:53 AM
munro_ip9.org updated the diff for D17166: Add a way to get version information from querylocale(3)..

New version because I missed one detail from yuripv's feedback (.Xr querylocaleversion 3).

Sep 14 2018, 7:22 AM
munro_ip9.org updated the diff for D17166: Add a way to get version information from querylocale(3)..

Man page tidying + more context, based on feedback from yuripv.

Sep 14 2018, 7:11 AM
munro_ip9.org added a reviewer for D17166: Add a way to get version information from querylocale(3).: bapt.
Sep 14 2018, 5:03 AM
munro_ip9.org retitled D17166: Add a way to get version information from querylocale(3). from Add querylocaleversion(). to Add querylocaleversion(3) to libc..
Sep 14 2018, 1:06 AM

Sep 13 2018

munro_ip9.org created D17166: Add a way to get version information from querylocale(3)..
Sep 13 2018, 11:16 PM

Aug 30 2018

munro_ip9.org closed D16111: Add setproctitle_fast() for frequent callers..
Aug 30 2018, 10:20 PM
munro_ip9.org accepted D16111: Add setproctitle_fast() for frequent callers..
Aug 30 2018, 10:12 PM
munro_ip9.org created D16950: pam_exec(8) expose_authtok should send a trailing NUL.
Aug 30 2018, 11:20 AM

Aug 15 2018

munro_ip9.org added a comment to D16171: Add expose_authtok option to pam_exec(8)..

Thanks!

Aug 15 2018, 10:30 AM

Jul 25 2018

munro_ip9.org added a comment to D16234: Add setproctitle_fast() patches to PostgreSQL 9.5, 9.6, 10 ports..

Would it make sense to check if "nm /path/to/postgres | grep setproctitle_fast"?

Jul 25 2018, 10:21 PM

Jul 24 2018

munro_ip9.org added a comment to D16111: Add setproctitle_fast() for frequent callers..

I'll commit the change to the PostgreSQL development branch soon, to affect PostgreSQL 12.

Jul 24 2018, 1:55 AM
munro_ip9.org added a comment to D16234: Add setproctitle_fast() patches to PostgreSQL 9.5, 9.6, 10 ports..

Looks good. We should probably also change the default configuration if setproctitle_fast exists. When was it introduced, in which OSVERSION?
files/patch-src_backend_utils_misc_postgresql.conf.sample turns setproctitle off.

Jul 24 2018, 1:29 AM

Jul 12 2018

munro_ip9.org added a comment to D16234: Add setproctitle_fast() patches to PostgreSQL 9.5, 9.6, 10 ports..
In D16234#344339, @mat wrote:

Has this been submitted upstream?

Jul 12 2018, 7:56 AM
munro_ip9.org added a comment to D16111: Add setproctitle_fast() for frequent callers..
In D16111#342204, @kib wrote:

Thanks kib! For the record, here's a patch for PostgreSQL that I plan to push when this makes it to a RELEASE:
https://www.postgresql.org/message-id/CAEepm%3D1wKMTi81uodJ%3D1KbJAz5WedOg%3Dcr8ewEXrUFeaxWEgww%40mail.gmail.com

Why waiting for a release ? There is a significant population of users utilizing stable, and even HEAD is sometimes used not only by developers. Early you push this into the wild world, more feedback you get.

Jul 12 2018, 5:25 AM
munro_ip9.org created D16234: Add setproctitle_fast() patches to PostgreSQL 9.5, 9.6, 10 ports..
Jul 12 2018, 5:22 AM

Jul 9 2018

munro_ip9.org updated the diff for D16171: Add expose_authtok option to pam_exec(8)..

Added handling for EAGAIN on write() (not sure if that case is reachable).

Jul 9 2018, 12:20 PM

Jul 7 2018

munro_ip9.org created D16171: Add expose_authtok option to pam_exec(8)..
Jul 7 2018, 11:26 AM

Jul 4 2018

munro_ip9.org added a comment to D16111: Add setproctitle_fast() for frequent callers..

Thanks kib! For the record, here's a patch for PostgreSQL that I plan to push when this makes it to a RELEASE:

Jul 4 2018, 10:33 PM
munro_ip9.org added inline comments to D16111: Add setproctitle_fast() for frequent callers..
Jul 4 2018, 2:57 AM

Jul 3 2018

munro_ip9.org added inline comments to D16111: Add setproctitle_fast() for frequent callers..
Jul 3 2018, 11:51 PM
munro_ip9.org updated the diff for D16111: Add setproctitle_fast() for frequent callers..

Updates from kib's code review.

Jul 3 2018, 11:50 PM
munro_ip9.org created D16111: Add setproctitle_fast() for frequent callers..
Jul 3 2018, 12:56 PM

May 12 2018

munro_ip9.org created D15399: Update procctl.2 man page to say that PROC_PDEATHSIG_CTL was added in 11.2..
May 12 2018, 12:47 AM

Apr 27 2018

munro_ip9.org created D15214: Remove redundant pipe from pdeathsig.c test..
Apr 27 2018, 11:07 AM

Apr 19 2018

munro_ip9.org added a comment to D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Thank you!

Apr 19 2018, 12:25 AM

Apr 18 2018

munro_ip9.org updated the diff for D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Fixed assertion about struct layout on i386. Fixed typo in man page (s/pont/point/).

Apr 18 2018, 8:48 AM
munro_ip9.org updated the diff for D15106: Add PROC_PDEATHSIG_SET to procctl interface..

The "fork_no_inherit" and "exec_inherit" tests' child processes also need to call _exit(0), so here's a new version to do that. Thanks for the review jilles. I agree the tests look much better with those changes.

Apr 18 2018, 3:22 AM
munro_ip9.org updated the diff for D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Used _exit(0) to exit the tests's subprocesses successfully. Use sigwait to wait for signals synchronously. Documentation tweaks.

Apr 18 2018, 12:09 AM

Apr 17 2018

munro_ip9.org updated the diff for D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Use 'p' instead of td->td_proc in one more place that I'd missed. (Thanks to mjg for prod via IRC.) Sorry for the churn.

Apr 17 2018, 1:51 AM
munro_ip9.org added a comment to D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Thanks for the reviews and help!

Apr 17 2018, 1:27 AM
munro_ip9.org updated the diff for D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Use 'p' variable instead of repeating td->td_proc, as requested.

Apr 17 2018, 1:24 AM

Apr 16 2018

munro_ip9.org updated the diff for D15106: Add PROC_PDEATHSIG_SET to procctl interface..

Updated documentation and moved PDEATHSIG handling into its own switch, as requested.

Apr 16 2018, 10:10 PM
munro_ip9.org created D15106: Add PROC_PDEATHSIG_SET to procctl interface..
Apr 16 2018, 8:28 PM