Page MenuHomeFreeBSD

Add setproctitle_fast() patches to PostgreSQL 9.5, 9.6, 10 ports.
Needs ReviewPublic

Authored by munro_ip9.org on Jul 12 2018, 5:22 AM.

Details

Reviewers
girgen
Summary

In https://reviews.freebsd.org/D16111 we got setproctitle_fast(), a way to speed up PostgreSQL's frequent process title updates on FreeBSD. I can get the PostgreSQL side of that committed to PostgreSQL 12, but it's not PostgreSQL project policy to backpatch new features to older releases (only bug fixes). How about carrying patches for the stable PostgreSQL releases in FreeBSD ports? Then 12-CURRENT users can benefit from the speed-up and provide feedback now. This covers PostgreSQL 9.5, 9.6 and 10. We can take care of PostgreSQL 11 when it's released, quite soon.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

munro_ip9.org created this revision.Jul 12 2018, 5:22 AM
mat added a comment.Jul 12 2018, 7:34 AM

Has this been submitted upstream?

In D16234#344339, @mat wrote:

Has this been submitted upstream?

Yep, here: https://commitfest.postgresql.org/19/1715/

girgen added a comment.EditedJul 12 2018, 10:56 AM

Looks good. We should probably also change the default configuration if setproctitle_fast exists. When was it introduced, in which OSVERSION?
files/patch-src_backend_utils_misc_postgresql.conf.sample turns setproctitle off.

Looks good. We should probably also change the default configuration if setproctitle_fast exists. When was it introduced, in which OSVERSION?
files/patch-src_backend_utils_misc_postgresql.conf.sample turns setproctitle off.

I'm not sure... isn't the important question whether the postgres binary was built with this option? If you're using a pkg compiled for 11.0 and you're running on 11.3, then your postgres binary doesn't use setproctitle_fast(), even though the OS has it. Would it make sense to check if "nm /path/to/postgres | grep setproctitle_fast"?

BTW I just pushed this change to PostgreSQL master (PostgreSQL 12-to-be).

Would it make sense to check if "nm /path/to/postgres | grep setproctitle_fast"?

I guess that should be "nm -D ...", since symbols might be stripped.

linimon removed a subscriber: linimon.May 10 2019, 12:11 AM