Page MenuHomeFreeBSD

Update sysutils/gomplate to 2.6.0
ClosedPublic

Authored by seanc on Jun 9 2018, 8:33 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seanc created this revision.Jun 9 2018, 8:33 PM
mat added a comment.Jun 11 2018, 7:22 AM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

seanc updated this revision to Diff 43599.Jun 11 2018, 12:41 PM

Full context

In D15722#332860, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I keep forgetting you prefer full context patches to review. I don't use anarchist because it pulls in PHP as a runtime dependency. Also, the UI should be able to navigate forward and backward without a developer needing to drop a huge patch. Anyway, my personal grumblings. I've updated the patch.

mat accepted this revision.Jun 11 2018, 4:25 PM
In D15722#332860, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I keep forgetting you prefer full context patches to review.

I like to be able to review the changes, to review the changes, it is easier to be able to see the whole files.

In this case, it was needed because the distinfo file was going from 2 files to 1 file, which was not mentionned in the review, so I was wondering if:

  • you had done something funny to generate the distinfo file and dropped the second file by mistake
  • the distinfo file had a stale entry from an earlier commit where the second distfile was removed
  • something else

turns out that it was something between the second and the third possibility, the port was added with a bogus distinfo file to begin with.

It should be mentioned in the commit, along the lines of "an extra file was removed from the distinfo, it had crept in when the port was added" or something.

I don't use anarchist because it pulls in PHP as a runtime dependency. Also, the UI should be able to navigate forward and backward without a developer needing to drop a huge patch. Anyway, my personal grumblings. I've updated the patch.

I don't understand how the UI would be able to invent the lines that are not in the patch :-)
(and I don't understand the "pulls in PHP as a runtime dependency" bit, but, well...)

This revision is now accepted and ready to land.Jun 11 2018, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I keep forgetting you prefer full context patches to review.

I like to be able to review the changes, to review the changes, it is easier to be able to see the whole files.

It makes sense, it's just not my normal workflow.

It should be mentioned in the commit, along the lines of "an extra file was removed from the distinfo, it had crept in when the port was added" or something.

Thanks, I added that to the commit message.

I don't use anarchist because it pulls in PHP as a runtime dependency. Also, the UI should be able to navigate forward and backward without a developer needing to drop a huge patch. Anyway, my personal grumblings. I've updated the patch.

I don't understand how the UI would be able to invent the lines that are not in the patch :-)

For another day.

(and I don't understand the "pulls in PHP as a runtime dependency" bit, but, well...)

If it doesn't compile to a static binary or requires an interpreter/sidecar VM, it's likely not going to be added to my local development systems.