- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 18 2019
Jan 10 2019
Jan 6 2019
Jan 4 2019
Dec 20 2018
Dec 19 2018
Dec 17 2018
Dec 12 2018
Dec 11 2018
Dec 1 2018
After commandeering the revision, updating it to make sure my diff is the same as the previously submitted diff.
After commandeering the revision, updating it to make sure my diff is
the same as the previously submitted diff.
I'll take over this diff and get it committed to -CURRENT in the next few days.
Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?
Nov 30 2018
@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?
@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?
This fix was (accidentally) committed in rS337812 and incorporated into the upcoming 12.0-RELEASE; I just noticed that now when I went to MFC that commit to stable/11. Closing the review now, considerably after the fact.
Nov 27 2018
Nov 19 2018
Nov 8 2018
@vangyzen, Looks OK to me but I'm curious how you ran across this situation.
Sep 16 2018
Sep 15 2018
@vangyzen -- Did you notice this:
Aug 21 2018
Looks good.
I would also agree with issuing a warning, masking the offending permission bits, and continuing.
This change has been merged upstream (netmap PR #520).
Aug 14 2018
Aug 7 2018
Jul 31 2018
Jul 30 2018
Jul 28 2018
Jul 27 2018
Jul 24 2018
Jul 23 2018
Jul 18 2018
Fix style issue pointed out by @kib.
Jul 17 2018
This review has been languishing for a bit.
Jul 12 2018
Updating to rebase off latest head revision (rS336219). No functional
change from previous diff.
Jul 11 2018
Jun 28 2018
Fixed by rS335765
Jun 20 2018
Update to do several things:
Jun 14 2018
Add a test for the re-add of a timer.
Fix a small panic-inducing typo.
Jun 13 2018
Jun 12 2018
Jun 11 2018
Revert an unintended change to the original EV_SET macro that crept into my last revision.
Jun 8 2018
Jun 7 2018
Add check for STDC_VERSION being defined before attempting to check its value.
Jun 6 2018
May 18 2018
I'd prefer the blank line be dropped, but I don't feel strongly about it.