Page MenuHomeFreeBSD

Use __SCCSID for SCCS IDs in libkvm sources.
ClosedPublic

Authored by jhb on May 16 2018, 8:59 PM.

Details

Summary

Rather than using #ifdef's around a static char array, use the
existing helper macro from <sys/cdefs.h> for SCCS IDs. To
preserve existing behavior, add -DNO__SCCSID to CFLAGS to not
include SCCS IDs in the built library by default.

Test Plan
  • Built a libkvm and compared 'readelf -p .comment' before and after.
  • Also accidentally got the CFLAGS wrong the first try which showed the SCCS IDs in .comment.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

LGTM. I'm not sure the blank line between FBSDID and SCCSID is useful, but don't care much one way or another.

This revision is now accepted and ready to land.May 16 2018, 9:12 PM

Yeah, I actually meant to post a comment asking about the blank line. I would be fine with collapsing it now that the ID isn't surrounded by N layers of #ifdef.

rgrimes added a subscriber: rgrimes.
In D15459#326241, @jhb wrote:

Yeah, I actually meant to post a comment asking about the blank line. I would be fine with collapsing it now that the ID isn't surrounded by N layers of #ifdef.

I would like to see the blank line collapsed.

Other than I like the decluttering effect this patch has.

Looks good to me. I could go either way on the blank line.

dab added a subscriber: dab.

I'd prefer the blank line be dropped, but I don't feel strongly about it.

  • Remove extra blank lines.
This revision now requires review to proceed.May 22 2018, 12:48 AM
This revision is now accepted and ready to land.May 22 2018, 1:12 AM
This revision was automatically updated to reflect the committed changes.