Page MenuHomeFreeBSD

Add uk.macbook.kbd keymap (vt)
ClosedPublic

Authored by dab on Fri, Nov 30, 5:24 PM.

Details

Summary

Added a new keymap for UK Macbook keyboards

Bugzilla ticket;
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215185

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste accepted this revision.Fri, Nov 30, 7:35 PM
This revision is now accepted and ready to land.Fri, Nov 30, 7:35 PM
dab added a subscriber: dab.Fri, Nov 30, 11:27 PM
dab added a comment.Fri, Nov 30, 11:30 PM

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

In D18395#391412, @dab wrote:

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Yes please, that would be great! I've been using the keymap on my MacBookAir (a UK model) for quite a few months now by setting in /etc/rc.conf;
"keymap="uk.macbook"

All the keys that were mapped incorrectly under the US layout (and the standard UK layout) now work fine such as; 2@€, 3£#, §±, etc.

dab commandeered this revision.Sat, Dec 1, 2:41 AM

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

In D18395#391434, @dab wrote:

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

I was originally testing it against CURRENT (r339826), but have since switched over to stable/12 (r340868) last week.

dab updated this revision to Diff 51480.Sat, Dec 1, 6:56 PM
dab edited the summary of this revision. (Show Details)
dab edited the test plan for this revision. (Show Details)

After commandeering the revision, updating it to make sure my diff is the same as the previously submitted diff.

This revision now requires review to proceed.Sat, Dec 1, 6:56 PM
dab edited the summary of this revision. (Show Details)Tue, Dec 11, 12:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Dec 11, 2:14 AM
Closed by commit rS341806: Add uk.macbook.kbd keymap (vt) (authored by dab, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.