• Fixed compilation error for the VF driver.

See attachment since Phabricator apparently didn't like the formatting of my paste...

It looks like ixv fails to build on 10/stable:

We noticed this issue awhile back and it was fixed in 11 but not in 10. We don't see it using our OOT components, only with in-kernel on 10.3. It makes it difficult to perform any modicum of validation w/o being able to load and unload the driver.

In D7802#163613, @jeffrey.e.pieper_intel.com wrote:

ixl seems to have some issues with netmap when loaded as module:

[root@u0753 ~]# kldload if_ixl
kldload: an error occurred while loading the module. Please check dmesg(8) for more details.
[root@u0753 ~]# dmesg
KLD if_ixl.ko: depends on netmap - not available or version mismatch
linker_load_file: Unsupported file typ

It loads fine at boot (with netmap) when compiled static in the kernel.

ixl seems to have some issues with netmap when loaded as module:

In D7802#163541, @jeffrey.e.pieper_intel.com wrote:

arc is failing to apply this, as it is trying to apply it to stable/10/sys/dev/ixl, but SHOULD be sys/dev/ixl. I had to apply it manually.

arc is failing to apply this, as it is trying to apply it to stable/10/sys/dev/ixl, but SHOULD be sys/dev/ixl. I had to apply it manually.

I haven't had a chance to test this yet, so you should probably hold off.

Do you want me to fire this off?

In D7802#162125, @sbruno wrote:

Which svn revisions is this going to MFC?

Did you have to change much from the original code for this MFC?

Which svn revisions is this going to MFC?

Do arc command from repository root.

I don't think the changelist looks right; this is supposed to apply to stable/10 and have mergeinfo, I think...

Thanks for getting this in, Sean.

Touch-tested on Kaby Lake, i219, ich10/82567, 82579, and 82574L.

Tested basic functionality, stress with netperf with both ixl and ixlv.

In D7391#154103, @sbruno wrote:

As far as I can tell, the error you're experiencing is from Phabricator, not the

In D7391#153674, @jeffrey.e.pieper_intel.com wrote:

The patch generated by Phabricator doesn't 'seem to manually apply to 11-BETA3 due the added files. It "should" just create them, but doesn't:

Hmm... The next patch looks like a unified diff to me...

The text leading up to this was:

Index: sys/dev/ixl/ixl_pf_iov.h

===================================================================

--- sys/dev/ixl/ixl_pf_iov.h

+++ sys/dev/ixl/ixl_pf_iov.h

---

File to patch: sys/dev/ixl/ixl_pf_iov.h
No file found--skip this patch? [n] n
patch: **** can't find sys/dev/ixl/ixl_pf_iov.h

Arc patch applies cleanly to stable/11, but fails to compile. Something in dtrace:

make[5]: make[5]: don't know how to make /diskless/os/FreeBSD/11-BETA3_2016-07-29_FPK/usr/src/sys/cddl/dev/dtrace/amd64/instr_size.c. Stop

the same kernel compiles and boots fine without the patch applied.

Try using arcanist (pkg install php5-arcanist) instead. Phabricator is definitely doing something wrong here.

"arc patch D7391" seems to work fine for me.

As far as I can tell, the error you're experiencing is from Phabricator, not the

ixl/ixlv: Fix INET not being defined by including option headers in central ixl.h header.

The patch generated by Phabricator doesn't 'seem to manually apply to 11-BETA3 due the added files. It "should" just create them, but doesn't:

In D7391#153621, @sbruno wrote:

I think we'd need a bit *more* of a commit log on this one. Any chance of getting a paragraph or two?

I think we'd need a bit *more* of a commit log on this one. Any chance of getting a paragraph or two?

Trying this again with a newer version of arcanist...

This needs to be regenerated. :-(

I see no objections here, so this should be committed.

applies cleanly, build started.

Ok, will do. I wish there was a nice way to lump a bunch of diffs together into one revision in Phabricator, though.

I'd like to see this broken down into a smaller set of changes. Single large changes like this are hard to review, debug, and, if there are problems, revert.

It wasn't clear from the summary that if this just adds new devices or also updates existing ones.