Page MenuHomeFreeBSD

em(4): Add Kaby Lake device IDs
ClosedPublic

Authored by erj on Aug 12 2016, 1:04 AM.

Details

Summary

The i219 in Kaby Lake devices is functionally the same as the i219 in Skylake devices, so the changes here are basically adding the device IDs to the driver's device list and switch statements.

There are additional changes that fix corner-case bugs with transitions to/from low power states.

Test Plan

Kernel (amd64) w/ patch builds on HEAD. Build for i386 in-progress...

Jeff is going to run more tests.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erj updated this revision to Diff 19213.Aug 12 2016, 1:04 AM
erj retitled this revision from to em(4): Add Kaby Lake device IDs.
erj updated this object.
erj edited the test plan for this revision. (Show Details)
erj set the repository for this revision to rS FreeBSD src repository.
erj added a project: Intel Networking.
erj edited the test plan for this revision. (Show Details)Aug 12 2016, 1:08 AM
erj edited edge metadata.
erj edited the test plan for this revision. (Show Details)Aug 12 2016, 1:11 AM
jeffrey.e.pieper_intel.com edited edge metadata.

Touch-tested on Kaby Lake, i219, ich10/82567, 82579, and 82574L.

This revision is now accepted and ready to land.Aug 12 2016, 9:07 PM
sbruno accepted this revision.Aug 15 2016, 9:35 AM
sbruno edited edge metadata.

stlgtm

This revision was automatically updated to reflect the committed changes.
erj added a comment.Aug 15 2016, 6:59 PM

Thanks for getting this in, Sean.