Page MenuHomeFreeBSD
Differential D7478

em(4): Add Kaby Lake device IDs
ClosedPublic
Actions

Authored by erj on Aug 12 2016, 1:04 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Nov 5, 3:57 AM
Unknown Object (File)
Sun, Nov 3, 9:28 PM
Unknown Object (File)
Thu, Oct 10, 3:42 AM
Unknown Object (File)
Oct 5 2024, 2:01 AM
Unknown Object (File)
Oct 4 2024, 9:57 AM
Unknown Object (File)
Oct 1 2024, 6:55 PM
Unknown Object (File)
Oct 1 2024, 4:30 PM
Unknown Object (File)
Oct 1 2024, 8:38 AM
View All 88 Files
Subscribers
imp

Details

Reviewers
jeffrey.e.pieper_intel.com
sbruno
Group Reviewers
Intel Networking
Commits
rS304149: e1000: Add support for Kaby Lake IDs
Summary

The i219 in Kaby Lake devices is functionally the same as the i219 in Skylake devices, so the changes here are basically adding the device IDs to the driver's device list and switch statements.

There are additional changes that fix corner-case bugs with transitions to/from low power states.

Test Plan

Kernel (amd64) w/ patch builds on HEAD. Build for i386 in-progress...

Jeff is going to run more tests.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4761
Build 4815: arc lint + arc unit

Event Timeline

erj updated this revision to Diff 19213.Aug 12 2016, 1:04 AM
erj retitled this revision from to em(4): Add Kaby Lake device IDs.
erj updated this object.
erj edited the test plan for this revision. (Show Details)
erj added reviewers: Intel Networking, jeffrey.e.pieper_intel.com.
erj set the repository for this revision to rS FreeBSD src repository - subversion.
erj added a project: Intel Networking.
Herald added a reviewer: sbruno. · View Herald TranscriptAug 12 2016, 1:04 AM
Herald added a subscriber: imp. · View Herald Transcript
erj edited the test plan for this revision. (Show Details)Aug 12 2016, 1:08 AM
erj edited edge metadata.
erj edited the test plan for this revision. (Show Details)Aug 12 2016, 1:11 AM
jeffrey.e.pieper_intel.com accepted this revision.Aug 12 2016, 9:07 PM
jeffrey.e.pieper_intel.com edited edge metadata.

Touch-tested on Kaby Lake, i219, ich10/82567, 82579, and 82574L.

This revision is now accepted and ready to land.Aug 12 2016, 9:07 PM
sbruno accepted this revision.Aug 15 2016, 9:35 AM
sbruno edited edge metadata.

stlgtm

Closed by commit rS304149: e1000: Add support for Kaby Lake IDs (authored by sbruno). · Explain WhyAug 15 2016, 11:24 AM
This revision was automatically updated to reflect the committed changes.
erj added a comment.Aug 15 2016, 6:59 PM

Thanks for getting this in, Sean.

Revision Contents
Changeset List

PathSize
sys/
dev/
e1000/
4 lines
8 lines
2 lines
17 lines
22 lines
6 lines

Diff 19213

View Options

sys/dev/e1000/e1000_api.c

Loading...
View Options

sys/dev/e1000/e1000_hw.h

Loading...
View Options

sys/dev/e1000/e1000_ich8lan.h

Loading...
View Options

sys/dev/e1000/e1000_ich8lan.c

Loading...
View Options

sys/dev/e1000/e1000_phy.c

Loading...
View Options

sys/dev/e1000/if_em.c

Loading...