Page MenuHomeFreeBSD
Feed Advanced Search

Mar 24 2016

gnn closed D4306: Re-add route caching for TCP by committing rS297225: FreeBSD previously provided route caching for TCP (and UDP). Re-add.
Mar 24 2016, 7:55 AM · transport
gnn accepted D4306: Re-add route caching for TCP.
Mar 24 2016, 7:51 AM · transport
gnn added a comment to D4306: Re-add route caching for TCP.

Having applied this to HEAD I find that with the following test:

Mar 24 2016, 7:51 AM · transport
gnn added a comment to D4306: Re-add route caching for TCP.

I'll give this a benchmark in the Sentex lab.

Mar 24 2016, 6:24 AM · transport

Mar 23 2016

gnn retitled D5716: Move mbuf provider under SDT to indicate that it is FreeBSD specific and not a stable interface. from to Move mbuf provider under SDT to indicate that it is FreeBSD specific and not a stable interface..
Mar 23 2016, 7:03 AM

Mar 22 2016

gnn committed rS297188: Add an mbuf provider to DTrace..
Add an mbuf provider to DTrace.
Mar 22 2016, 1:17 PM
gnn closed D5682: Add an mbuf provider for DTrace by committing rS297188: Add an mbuf provider to DTrace..
Mar 22 2016, 1:17 PM
gnn updated the diff for D5682: Add an mbuf provider for DTrace.

Updates to get all the return values out.

Mar 22 2016, 12:56 PM
gnn accepted D5033: VNET: factor out nd6 and in6_attach initialisation and teardown.
Mar 22 2016, 11:31 AM
gnn accepted D5698: Plug mbuf leak in m_unshare..
Mar 22 2016, 12:08 AM

Mar 21 2016

gnn added inline comments to D5682: Add an mbuf provider for DTrace.
Mar 21 2016, 3:05 PM
gnn updated the diff for D5682: Add an mbuf provider for DTrace.

Address comments from bz@

Mar 21 2016, 3:05 PM
gnn updated the diff for D5682: Add an mbuf provider for DTrace.

Update m_getcl provider to also pass the flags.

Mar 21 2016, 1:37 PM

Mar 19 2016

gnn updated the diff for D5682: Add an mbuf provider for DTrace.

Add the mbuf.d translation file.

Mar 19 2016, 2:45 PM
gnn updated the diff for D5682: Add an mbuf provider for DTrace.

Add translators.

Mar 19 2016, 2:40 PM
gnn added a reviewer for D5682: Add an mbuf provider for DTrace: olivier.
Mar 19 2016, 11:22 AM
gnn updated D5682: Add an mbuf provider for DTrace.
Mar 19 2016, 11:19 AM
gnn retitled D5682: Add an mbuf provider for DTrace from to Add an mbuf provider for DTrace.
Mar 19 2016, 11:17 AM

Mar 16 2016

gnn added a reviewer for D4306: Re-add route caching for TCP: olivier.
Mar 16 2016, 8:02 AM · transport
gnn added a comment to D4306: Re-add route caching for TCP.

I've added Olivier as a reviewer because I'm hoping he'll test this patch and give us some updated performance numbers.

Mar 16 2016, 8:02 AM · transport
gnn updated subscribers of D4306: Re-add route caching for TCP.
Mar 16 2016, 8:01 AM · transport
gnn accepted D801: Add 802.1p priority code point to vlan(4)..

Do it.

Mar 16 2016, 1:59 AM
gnn accepted D4593: Implement a stripped down version of GELI (AES-XTS and AES-CBC only) in gptboot and gptzfsboot.

It looks like most of the issues are addressed and this can go in. I've not run the code but I have read it over.

Mar 16 2016, 12:56 AM

Mar 14 2016

gnn committed rS296829: Fix typo: nmd->cur_tx_ring should be used in pci_vtnet_netmap_writev().
Fix typo: nmd->cur_tx_ring should be used in pci_vtnet_netmap_writev()
Mar 14 2016, 8:48 AM
gnn closed D5595: Bug fixes for netmap support in bhyve by committing rS296829: Fix typo: nmd->cur_tx_ring should be used in pci_vtnet_netmap_writev().
Mar 14 2016, 8:48 AM
gnn accepted D5595: Bug fixes for netmap support in bhyve.
Mar 14 2016, 8:24 AM

Mar 9 2016

gnn accepted D4306: Re-add route caching for TCP.

4102 has already gone in. It's time to push this in as well.

Mar 9 2016, 1:49 AM · transport

Mar 4 2016

gnn accepted D5431: Reduce thread count in driver to reduce out of order transmit processing.
Mar 4 2016, 1:47 PM

Mar 3 2016

gnn committed rS296370: MFC 285730.
MFC 285730
Mar 3 2016, 11:25 PM
gnn committed rS296352: Fix dtrace probes (introduced in 287759): debug__input was used.
Fix dtrace probes (introduced in 287759): debug__input was used
Mar 3 2016, 5:47 PM
gnn closed D5525: Fix dtrace probes for TCPDEBUG by committing rS296352: Fix dtrace probes (introduced in 287759): debug__input was used.
Mar 3 2016, 5:47 PM
gnn added reviewers for D5525: Fix dtrace probes for TCPDEBUG: rrs, jtl, hiren.
Mar 3 2016, 2:48 AM
gnn committed rS296335: fix tcpdebug: - assign to "flags" in each probe, not only debug-input.
fix tcpdebug: - assign to "flags" in each probe, not only debug-input
Mar 3 2016, 2:46 AM
gnn closed D5524: fixes on DTrace tcpdebug script by committing rS296335: fix tcpdebug: - assign to "flags" in each probe, not only debug-input.
Mar 3 2016, 2:46 AM

Feb 25 2016

gnn accepted D5448: Fix missing brackets in e1000_phy.c.
Feb 25 2016, 9:25 PM

Feb 22 2016

gnn accepted D5163: MFC r272514 Switch ipfw to use rmlock for runtime locking..
Feb 22 2016, 11:15 PM
gnn added a reverting change for rS295285: MFC: r290383,295282,295283: rS295896: Revert 295285 which was an MFC of the tryforward work (r290383,295282,295283).
Feb 22 2016, 7:18 PM
gnn committed rS295896: Revert 295285 which was an MFC of the tryforward work (r290383,295282,295283).
Revert 295285 which was an MFC of the tryforward work (r290383,295282,295283)
Feb 22 2016, 7:18 PM

Feb 20 2016

gnn added a comment to D5330: Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT..

I wonder if you can get some pmc results on this code to see what's causing the difference? I suspect caching issues, but that's just a guess. I'm going to move forward with a change to how this all works in HEAD, following the suggestion in the comment. that will take a while to work out because icmp_error() likes to free mbufs and if we have one on the stack that will not go well.

Feb 20 2016, 3:39 PM

Feb 19 2016

gnn added a comment to D5330: Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT..

I'm not sure how that trace could be related to this but if I can get a core dump it might help.

Feb 19 2016, 5:18 PM
gnn added a comment to D5330: Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT..

What I found in my setup was that this reduced performance by 5% but that is a pull back from a 25% increase. Can you also compare this against plain forwarding on 10.2? The comparisons that matter are:

Feb 19 2016, 4:34 PM

Feb 18 2016

gnn added a comment to D5330: Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT..

Thanks.

Feb 18 2016, 11:41 PM
gnn retitled D5330: Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT. from to Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT..
Feb 18 2016, 6:53 PM
gnn committed rS295763: Free Eric Joyner from mentorship..
Free Eric Joyner from mentorship.
Feb 18 2016, 5:10 PM

Feb 13 2016

gnn added a comment to D3934: Request review of new FreeBSD web site.

If someone wants this to happen it has to be taken up by the project NOW. The original author has moved on. Or, you know, we could just abandon good work on this for the Nth time.

Feb 13 2016, 11:29 AM

Feb 10 2016

gnn accepted D5239: Fix comparison function in LRO.

Thank you.

Feb 10 2016, 2:10 PM
gnn requested changes to D5239: Fix comparison function in LRO.

We are programming in C and not assembler. Please make the requested change to a typically C idiom.

Feb 10 2016, 2:00 PM
gnn accepted D5240: sfxge: implement SIOCGI2C to read infromation from phy modules.
Feb 10 2016, 12:08 PM

Feb 5 2016

gnn added a comment to D4994: Make quicksort or mergesort configurable for the LRO code..

If the performance is the same then I think using the tried and true algorithm wins out over putting a new one in specifically just for this case.

Feb 5 2016, 12:03 AM

Feb 4 2016

gnn added inline comments to D5180: Gather all mbuf(9) allocation APIs in one place.
Feb 4 2016, 11:56 PM
gnn committed rS295285: MFC: r290383,295282,295283.
MFC: r290383,295282,295283
Feb 4 2016, 10:53 PM
gnn committed rS295283: Summary: Update the date.
Summary: Update the date
Feb 4 2016, 9:47 PM
gnn committed rS295282: Summary: Remove discussion of fastforwarding..
Summary: Remove discussion of fastforwarding.
Feb 4 2016, 9:40 PM

Feb 3 2016

gnn accepted D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

Approved.

Feb 3 2016, 7:54 PM

Jan 21 2016

gnn accepted D5024: Implement sysctl for the min/max values of the TCP persist timer.
Jan 21 2016, 9:23 PM
gnn added a comment to D5017: More than 65K connection from single application.

I'm a bit confused by this proposal. No protocol I know of has a port field larger than 16 bits. How and where might this be applied?

Jan 21 2016, 5:03 PM · network

Jan 20 2016

gnn added a comment to D4994: Make quicksort or mergesort configurable for the LRO code..

Can we see some numbers that support switching from the well known, and validated, qsort() to this private version of mergesort? If this is a win then we probably want an abstracted version of this to sit along side our qsort.

Jan 20 2016, 10:39 PM

Jan 19 2016

gnn accepted D4914: Optimise LRO for RSS.
Jan 19 2016, 3:25 PM

Jan 18 2016

gnn added a comment to D4808: Add basic TCP options to tcp_respond().

Has this been updated based on all the recent rototilling?

Jan 18 2016, 11:42 PM
gnn committed rS294294: MFC: 293459,293643.
MFC: 293459,293643
Jan 18 2016, 9:24 PM

Jan 17 2016

gnn accepted D4964: Protect calls to explicit_bzero() via by explicitly disabling the link-time and other optimizations that can cause code elimination..

I'm down with this but I will also push the other reviewers to take a look before committing.

Jan 17 2016, 8:00 PM

Jan 15 2016

gnn accepted D4955: Add arm64 and riscv to the list of supported architectures.

Accepted on behalf of core@

Jan 15 2016, 5:13 PM
gnn accepted D4952: sfxge: check the RX DMA end padding configuration on Medford.
Jan 15 2016, 2:47 PM
gnn accepted D4951: sfxge: convert nvram read method to use partition id.
Jan 15 2016, 2:47 PM
gnn accepted D4950: sfxge: rename Huntington MAC methods to EF10 and use for Medford.
Jan 15 2016, 2:47 PM
gnn accepted D4949: sfxge: rename common hunt PHY methods to ef10 and use for Medford.
Jan 15 2016, 2:47 PM

Jan 14 2016

gnn accepted D4937: sfxge: convert nvram rw_start method to use partition id.
Jan 14 2016, 9:04 PM
gnn accepted D4936: sfxge: Medford still needs fallback for no privilege mask.
Jan 14 2016, 9:04 PM
gnn accepted D4935: sfxge: medford stores a single global copy of VPD.
Jan 14 2016, 9:04 PM
gnn accepted D4934: sfxge: support FATSOv2.
Jan 14 2016, 9:04 PM
gnn accepted D4933: sfxge: rework MCDI request completion.
Jan 14 2016, 9:03 PM
gnn accepted D4932: sfxge: rename hunt_link_state_t to ef10_link_state_t.
Jan 14 2016, 9:03 PM
gnn accepted D4938: sfxge: cleanup: simplify ef10_get_datapath_caps.
Jan 14 2016, 9:03 PM
gnn accepted D4817: mlx5en: Allow RX and TX pause frames to be set through ifconfig.
Jan 14 2016, 8:49 PM
gnn accepted D4817: mlx5en: Allow RX and TX pause frames to be set through ifconfig.

This is

Jan 14 2016, 8:49 PM
gnn accepted D4898: Remove dead code from igmp.c.
Jan 14 2016, 8:19 PM
gnn accepted D4939: mlx5en: Fix declaration of variables.
Jan 14 2016, 8:16 PM
gnn accepted D4940: mlx5en: Add clarifying comment about CQE zipping.
Jan 14 2016, 8:16 PM
gnn accepted D4941: mlx5en: Rework code which checks the HW LRO sysctl.
Jan 14 2016, 8:16 PM

Jan 13 2016

gnn accepted D4919: sfxge: cleanup: quieten efx_mcdi_read_resonse_header error reporting.
Jan 13 2016, 4:06 PM
gnn accepted D4918: sfxge: add accessors for license-related MCDI calls to common code.
Jan 13 2016, 4:06 PM
gnn accepted D4917: sfxge: add table entries for License NVRAM partition.
Jan 13 2016, 4:06 PM
gnn accepted D4916: sfxge: cleanup: adjust efx_mcdi_get_port_modes() comment for clarity.
Jan 13 2016, 4:05 PM
gnn accepted D4915: sfxge: fix common code VPD iterator and duplicate tag verificat.
Jan 13 2016, 4:05 PM
gnn accepted D4913: sfxge: use correct register definitions for setting interrupt moderation on Medford.
Jan 13 2016, 4:05 PM
gnn accepted D4912: sfxge: support FATSOv2 in common code.
Jan 13 2016, 4:05 PM
gnn accepted D4911: sfxge: rx_prefix_pktlen methods do not require EFSYS_OPT_RX_SCALE.
Jan 13 2016, 4:04 PM
gnn accepted D4910: sfxge: convert nvram size method to use partition id.
Jan 13 2016, 4:04 PM
gnn accepted D4909: sfxge: rework MCDI start request.
Jan 13 2016, 4:04 PM
gnn accepted D4908: sfxge: add Medford NIC methods.
Jan 13 2016, 4:04 PM

Jan 12 2016

gnn accepted D4896: sfxge: support MC_CMD_GET_CAPABILITIES_V2.
Jan 12 2016, 11:49 PM
gnn accepted D4892: sfxge: note VI_SHIFT reported in ALLOC_VIS response.
Jan 12 2016, 11:49 PM
gnn accepted D4894: sfxge: simplify MCDI request start.
Jan 12 2016, 11:49 PM
gnn accepted D4895: sfxge: simplify conversion of NVRAM types to/from partition ids.
Jan 12 2016, 11:48 PM
gnn accepted D4889: sfxge: rework RX prefix handling in the common code.
Jan 12 2016, 11:48 PM
gnn accepted D4897: sfxge: add Medford firmware subtypes definitions.
Jan 12 2016, 11:47 PM
gnn accepted D4891: sfxge: remove obsolete lookahead split RXQ support.
Jan 12 2016, 2:50 PM
gnn accepted D4883: sfxge: remove obsolete efx_mac_hash_set() from common code.
Jan 12 2016, 2:49 PM
gnn accepted D4886: sfxge: fix interrupt handling for Medford.
Jan 12 2016, 2:48 PM
gnn accepted D4890: sfxge: pass context type and num_queues to efx_mcdi_rss_context_alloc.
Jan 12 2016, 2:48 PM