Add a set of SDTs for mbuf allocation and free routines. I'll add a translator in a followup commit.
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
A few pondering...
sys/kern/kern_mbuf.c | ||
---|---|---|
759 ↗ | (On Diff #14476) | Why do you not probe on the return value are as you do in uipc_mbuf? Consistency would be good I think. |
sys/sys/mbuf.h | ||
46 ↗ | (On Diff #14476) | Why do you need a new #ifdef KERNEL section here? I guess the hidden include for SDT is hard to avoid? |
695 ↗ | (On Diff #14476) | I wondered if this is more meaningful here or at the end, but given the two return paths it might be harder; I wonder if we should initialise error to 0, have one return and also report the return value? |
759 ↗ | (On Diff #14476) | Can you move this to the bottom so that the mbuf will have all the values set, which might make it more usable as args in a d-script? |
Address comments from bz@
sys/sys/mbuf.h | ||
---|---|---|
46 ↗ | (On Diff #14476) | Because I want this to be of a whole piece and various bits of non kernel code include mbuf.h |
Looks good now from what I can see. Thanks for this! :)
sys/sys/mbuf.h | ||
---|---|---|
705 ↗ | (On Diff #14477) | In theory you don't need the {} anymore |