Page MenuHomeFreeBSD

Bug fixes for netmap support in bhyve
ClosedPublic

Authored by btw on Mar 9 2016, 4:00 AM.

Details

Summary

Fix a couple of silly mistakes.

  • Fix typo: nmd->cur_tx_ring should be used in pci_vtnet_netmap_writev()
  • The buffer length should be checked to avoid overflow, but there is no API to get the slot length, so the hardcoded value is used.
  • Return the currently-first request chain back to the available queue if there is no more packets.
  • Report the link as up if we managed to open vale port.
  • Use consistent coding style.

This[1] is the worst patch I have ever submitted. I'm very guilty for
that, and I promise it won't happen again.

[1] https://lists.freebsd.org/pipermail/freebsd-virtualization/2015-January/003350.html

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

btw retitled this revision from to Fix a couple of silly mistakes..
btw updated this object.
btw edited the test plan for this revision. (Show Details)
btw added a reviewer: gnn.
btw retitled this revision from Fix a couple of silly mistakes. to Bug fixes for netmap support in bhyve.Mar 9 2016, 4:13 AM
btw updated this object.

This patch fix my problem on -head (r296650): guests VM using vale showing their vtnet interfaces with a status "no carrier".

gnn edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2016, 8:24 AM
This revision was automatically updated to reflect the committed changes.