Page MenuHomeFreeBSD

btw (Tiwei Bie)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 9:05 AM (379 w, 6 d)

Recent Activity

Mar 9 2016

btw retitled D5595: Bug fixes for netmap support in bhyve from Fix a couple of silly mistakes. to Bug fixes for netmap support in bhyve.
Mar 9 2016, 4:13 AM
btw added a reviewer for D5595: Bug fixes for netmap support in bhyve: grehan.
Mar 9 2016, 4:04 AM
btw retitled D5595: Bug fixes for netmap support in bhyve from to Fix a couple of silly mistakes..
Mar 9 2016, 4:00 AM

Jan 9 2016

btw added a comment to D4826: Add netmap support to bhyve.

Yeah, the bug is unrelated to this patch. I'll open a PR against netmap and won't let it block committing work! And thank you very much for being willing to commit this patch! ^_^

Jan 9 2016, 2:18 AM

Jan 8 2016

btw added a comment to D4826: Add netmap support to bhyve.

I'm testing on the master branch of the repo cloned from https://github.com/freebsd/freebsd.git with GENERIC conf on a desktop computer. And I can also reproduce this panic in VirtualBox with the image downloaded from http://mirrors.aliyun.com/freebsd/snapshots/VM-IMAGES/11.0-CURRENT/amd64/20151217/FreeBSD-11.0-CURRENT-amd64-20151217-r292413.vhd.xz

Jan 8 2016, 5:07 PM
btw added a comment to D4826: Add netmap support to bhyve.

I tried to test this patch on -HEAD, but it caused kernel panic. It seems that there is a bug in the kqueue support code of netmap. And I can reproduce the kernel panic with this simple program on -HEAD:

Jan 8 2016, 4:37 PM

Oct 9 2015

btw added a comment to D3563: Create a new IPv6 netisr which expects the frames to have been verified.
In D3563#79576, @adrian wrote:

ok, this looks good. I'll see if I can get gnn / bz to review this before I commit it to -HEAD.

Thanks very much for digging into this!

Oct 9 2015, 7:40 AM
btw updated the diff for D3563: Create a new IPv6 netisr which expects the frames to have been verified.

Replace the error handling code in ip6_direct_input() with KASSERT(), because this tag is mandatory.

Oct 9 2015, 7:28 AM
btw added a comment to D3563: Create a new IPv6 netisr which expects the frames to have been verified.

I mean this line!!!

Oct 9 2015, 4:53 AM
btw added a comment to D3563: Create a new IPv6 netisr which expects the frames to have been verified.

Oops! I didn't mean this line!

Oct 9 2015, 4:51 AM
btw added inline comments to D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Oct 9 2015, 3:59 AM
btw added a comment to D3563: Create a new IPv6 netisr which expects the frames to have been verified.
In D3563#79549, @adrian wrote:

Right - so it may have a new src/dst L3/L4 which means it needs to go back through the stack.

So as long as it's going back through and getting re-hashed on its trip though, I think we're okay.

How about adding a counter for when we drop frames on that direct dispatch v6 netisr so people can see when things are failing? Then I think we'll be ready.

Oct 9 2015, 3:57 AM
btw added inline comments to D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Oct 9 2015, 3:05 AM
btw added a comment to D3563: Create a new IPv6 netisr which expects the frames to have been verified.

I have defined a struct to save the context info for reinjecting. Many thanks! ^_^

Oct 9 2015, 1:57 AM
btw updated the diff for D3563: Create a new IPv6 netisr which expects the frames to have been verified.

Define a struct to save the context info for reinjecting.

Oct 9 2015, 1:52 AM

Oct 8 2015

btw updated the diff for D3563: Create a new IPv6 netisr which expects the frames to have been verified.

Use an mbuf tag instead of the mis-understood fields.

Oct 8 2015, 3:15 PM

Sep 19 2015

btw accepted D3686: UDP-Lite fixes.
Sep 19 2015, 5:11 PM

Sep 18 2015

btw added inline comments to D3686: UDP-Lite fixes.
Sep 18 2015, 2:27 PM

Sep 17 2015

btw abandoned D3414: Fix build on the latest projects/ifnet branch.
Sep 17 2015, 12:11 PM
btw added a reviewer for D3686: UDP-Lite fixes: btw.
Sep 17 2015, 11:49 AM

Sep 13 2015

btw updated the test plan for D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 13 2015, 2:49 PM
btw added inline comments to D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 13 2015, 2:42 PM
btw updated the diff for D3563: Create a new IPv6 netisr which expects the frames to have been verified.

Fix various bugs.

Sep 13 2015, 2:30 PM
btw reclaimed D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 13 2015, 2:19 PM
btw updated the diff for D3645: Remove duplicate RSS hash recalculation code..

Remove some obsolete comments about the flowid of directly dispatched frames.
Now the flowid of directly dispatched frames will be recalculated by
rss_soft_m2cpuid_v4() if needed. So there is no such assumption any more.

Sep 13 2015, 6:46 AM
btw updated the test plan for D3645: Remove duplicate RSS hash recalculation code..
Sep 13 2015, 1:56 AM
btw retitled D3645: Remove duplicate RSS hash recalculation code. from to Remove duplicate RSS hash recalculation code..
Sep 13 2015, 1:47 AM

Sep 11 2015

btw abandoned D3563: Create a new IPv6 netisr which expects the frames to have been verified.

This patch requires more work. I'm so sorry!!! >_<

Sep 11 2015, 3:59 PM

Sep 10 2015

btw updated the test plan for D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 10 2015, 3:05 PM
btw updated the diff for D3563: Create a new IPv6 netisr which expects the frames to have been verified.

Fix the bug related to atomic fragments in the previous patch
Atomic fragments should also be dispatched to ip6_direct.

Sep 10 2015, 3:01 PM

Sep 7 2015

btw added inline comments to D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 7 2015, 12:52 AM

Sep 4 2015

btw updated the test plan for D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 4 2015, 12:42 PM
btw updated the test plan for D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 4 2015, 12:25 PM
btw updated the test plan for D3563: Create a new IPv6 netisr which expects the frames to have been verified.
Sep 4 2015, 8:59 AM
btw added reviewers for D3562: Add support for receiving flowtype, flowid and RSS bucket information as part of recvmsg(): hiren, gnn.
Sep 4 2015, 7:48 AM
btw added reviewers for D3563: Create a new IPv6 netisr which expects the frames to have been verified: hiren, gnn.
Sep 4 2015, 7:47 AM
btw added reviewers for D3564: Replace rss_m2cpuid with rss_soft_m2cpuid_v4 for ip_direct_nh.nh_m2cpuid, because the RSS hash may need to be recalculated: hiren, gnn.
Sep 4 2015, 7:47 AM

Sep 3 2015

btw retitled D3564: Replace rss_m2cpuid with rss_soft_m2cpuid_v4 for ip_direct_nh.nh_m2cpuid, because the RSS hash may need to be recalculated from to Replace rss_m2cpuid with rss_soft_m2cpuid_v4 for ip_direct_nh.nh_m2cpuid, because the RSS hash may need to be recalculated.
Sep 3 2015, 11:51 PM
btw retitled D3563: Create a new IPv6 netisr which expects the frames to have been verified from to Create a new IPv6 netisr which expects the frames to have been verified.
Sep 3 2015, 11:45 PM
btw retitled D3562: Add support for receiving flowtype, flowid and RSS bucket information as part of recvmsg() from to Add support for receiving flowtype, flowid and RSS bucket information as part of recvmsg().
Sep 3 2015, 11:21 PM

Aug 28 2015

btw retitled D3510: Fix a typo in comment from to Fix a typo in comment.
Aug 28 2015, 3:36 AM

Aug 27 2015

btw retitled D3504: Implement IPv6 RSS software hash functions to use during packet ingress and egress from to Implement IPv6 RSS software hash functions to use during packet ingress and egress.
Aug 27 2015, 12:54 PM
btw updated the diff for D3471: Replace the printf()s with optional rate limited debugging for RSS.

Use ppsratelimit() for doing message rate limiting and and a global rate limit (maxpps, ie. the 3rd parameter of ppsratelimit()) for RSS.

Aug 27 2015, 7:10 AM
btw added a comment to D3471: Replace the printf()s with optional rate limited debugging for RSS.
In D3471#71596, @adrian wrote:

Actually, we've hand-rolled 'ratecheck()'. Would you like to modify your code to use ppsratecheck() instead? That'd make this all much easier.

Aug 27 2015, 7:08 AM

Aug 24 2015

btw retitled D3471: Replace the printf()s with optional rate limited debugging for RSS from to Replace the printf()s with optional rate limited debugging for RSS.
Aug 24 2015, 3:01 PM

Aug 20 2015

btw added a comment to D3423: Implement the IPv6 RSS software hash function.
In D3423#70070, @gnn wrote:

Shouldn't the printf() be under a debug statement?

Aug 20 2015, 12:00 PM

Aug 19 2015

btw retitled D3427: Add the UDP tools for multiqueue testing from to Add the UDP tools for multiqueue testing.
Aug 19 2015, 10:09 AM
btw retitled D3426: Add the TCP tools for multiqueue testing from to Add the TCP tools for multiqueue testing.
Aug 19 2015, 10:06 AM
btw retitled D3425: Implement the kernel module vme (Virtual Multiqueue Ethernet interface) based on tap(4) from to Implement the kernel module vme (Virtual Multiqueue Ethernet interface) based on tap(4).
Aug 19 2015, 10:04 AM
btw retitled D3424: Create a directory for the multiqueue testing from to Create a directory for the multiqueue testing.
Aug 19 2015, 10:01 AM
btw retitled D3423: Implement the IPv6 RSS software hash function from to Implement the IPv6 RSS software hash function.
Aug 19 2015, 9:59 AM
btw retitled D3422: Extend netstat(1) to report the statistics of ifring from to Extend netstat(1) to report the statistics of ifring.
Aug 19 2015, 9:56 AM
btw retitled D3421: Add a sysctl interface to export the statistics stored in ifring to userspace from to Add a sysctl interface to export the statistics stored in ifring to userspace.
Aug 19 2015, 9:54 AM
btw retitled D3420: Convert re(4) to use the per-ring counters from to Convert re(4) to use the per-ring counters.
Aug 19 2015, 9:50 AM
btw retitled D3419: Convert lo(4) to use the per-ring counters from to Convert lo(4) to use the per-ring counters.
Aug 19 2015, 9:48 AM
btw retitled D3418: Add the supports for allocating per-ring counters to ifnet KPI from to Add the supports for allocating per-ring counters to ifnet KPI.
Aug 19 2015, 9:45 AM
btw retitled D3417: Add the hooks in each layer of the network stack to collect the per-ring statistics from to Add the hooks in each layer of the network stack to collect the per-ring statistics.
Aug 19 2015, 9:41 AM
btw retitled D3416: Extend pkthdr to save the pointer to the ifring on which the packet is received from to Extend pkthdr to save the pointer to the ifring on which the packet is received.
Aug 19 2015, 9:37 AM
btw retitled D3415: Implement the ifring structure and helper macros to store and collect the per-ring statistics from to Implement the ifring structure and helper macros to store and collect the per-ring statistics.
Aug 19 2015, 9:34 AM
btw retitled D3414: Fix build on the latest projects/ifnet branch from to Fix build on the latest projects/ifnet branch.
Aug 19 2015, 9:31 AM