Page MenuHomeFreeBSD
Differential D3471

Replace the printf()s with optional rate limited debugging for RSS
ClosedPublic
Actions

Authored by btw on Aug 24 2015, 3:01 PM.
Tags
None
Referenced Files
F103318395: D3471.id8167.diff
Sat, Nov 23, 11:56 AM
Unknown Object (File)
Tue, Nov 19, 10:35 PM
Unknown Object (File)
Tue, Nov 5, 9:49 AM
Unknown Object (File)
Tue, Nov 5, 9:49 AM
Unknown Object (File)
Tue, Nov 5, 9:47 AM
Unknown Object (File)
Tue, Nov 5, 9:46 AM
Unknown Object (File)
Sun, Nov 3, 6:31 AM
Unknown Object (File)
Oct 2 2024, 11:36 PM
View All Files
Subscribers
imp

Details

Reviewers
hiren
gnn
adrian
Commits
rS287245: Replace the printf()s with optional rate limited debugging for RSS.
Summary

Replace the printf()s with optional rate limited debugging for RSS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btw updated this revision to Diff 8167.Aug 24 2015, 3:01 PM
btw retitled this revision from to Replace the printf()s with optional rate limited debugging for RSS.
btw updated this object.
btw edited the test plan for this revision. (Show Details)
btw added reviewers: adrian, gnn, hiren.
btw set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptAug 24 2015, 3:01 PM
gnn accepted this revision.Aug 24 2015, 3:32 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2015, 3:32 PM
adrian accepted this revision.Aug 27 2015, 5:39 AM
adrian edited edge metadata.
adrian added a comment.Aug 27 2015, 5:42 AM

Actually, we've hand-rolled 'ratecheck()'. Would you like to modify your code to use ppsratecheck() instead? That'd make this all much easier.

sys/net/rss_config.h
105 ↗(On Diff #8167)

Use ppsratecheck() here and a global rate limit timeval for RSS.

btw added a comment.Aug 27 2015, 7:08 AM
In D3471#71596, @adrian wrote:

Actually, we've hand-rolled 'ratecheck()'. Would you like to modify your code to use ppsratecheck() instead? That'd make this all much easier.

Sure!

btw updated this revision to Diff 8248.EditedAug 27 2015, 7:10 AM
btw edited edge metadata.

Use ppsratelimit() for doing message rate limiting and and a global rate limit (maxpps, ie. the 3rd parameter of ppsratelimit()) for RSS.

This revision now requires review to proceed.Aug 27 2015, 7:10 AM
adrian added a comment.Aug 28 2015, 5:57 AM

I'm okay with this, we can replace it with SDT stuff when it's ready.

adrian accepted this revision.Aug 28 2015, 5:57 AM
adrian edited edge metadata.

I'm okay with this, we can replace it with SDT stuff when it's ready.

This revision is now accepted and ready to land.Aug 28 2015, 5:57 AM
Closed by commit rS287245: Replace the printf()s with optional rate limited debugging for RSS. (authored by adrian). · Explain WhyAug 28 2015, 5:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net/
15 lines
22 lines
netinet/
14 lines
netinet6/
2 lines

Diff 8278

View Options

head/sys/net/rss_config.h

Loading...
View Options

head/sys/net/rss_config.c

Loading...
View Options

head/sys/netinet/in_rss.c

Loading...
View Options

head/sys/netinet6/in6_rss.c

Loading...