Page MenuHomeFreeBSD
Differential D33222

NXP: Implement errata workaround for SDHCI driver
ClosedPublic
Actions

Authored by hum_semihalf.com on Dec 1 2021, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 5:38 AM
Unknown Object (File)
Thu, May 9, 2:29 PM
Unknown Object (File)
Tue, May 7, 9:47 PM
Unknown Object (File)
Tue, May 7, 9:47 PM
Unknown Object (File)
Tue, May 7, 9:47 PM
Unknown Object (File)
Tue, May 7, 9:47 PM
Unknown Object (File)
Tue, May 7, 6:15 PM
Unknown Object (File)
Sun, Apr 28, 6:11 AM
View All 42 Files
Subscribers
bz
contact_artur-rojek.eu
imp
kd

Details

Reviewers
mw
wma
manu
bz
Commits
rG3785106a5bd9: sdhci_fsl_fdt: Implement pulse width detection errata
Summary

Some boards do not detect pulse width reliably. Implement workaround
by writing 0 to special register. Apply errata for board by adding
flag to chosen soc specific data.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hum_semihalf.com created this revision.Dec 1 2021, 2:46 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 1 2021, 2:46 PM
hum_semihalf.com requested review of this revision.Dec 1 2021, 2:46 PM
manu accepted this revision.Dec 1 2021, 2:55 PM
manu added inline comments.
sys/dev/sdhci/sdhci_fsl_fdt.c
5

You need to add 2020-2021

This revision is now accepted and ready to land.Dec 1 2021, 2:55 PM
hum_semihalf.com updated this revision to Diff 99308.Dec 1 2021, 3:06 PM

Change time period in license entry from 2021 to 2020 - 2021.

This revision now requires review to proceed.Dec 1 2021, 3:06 PM
mw accepted this revision.Dec 1 2021, 3:13 PM
This revision is now accepted and ready to land.Dec 1 2021, 3:13 PM
contact_artur-rojek.eu added a subscriber: contact_artur-rojek.eu.Dec 2 2021, 12:05 PM
hum_semihalf.com added a child revision: D33318: sdhci_fsl_fdt: Add LS1012A compat string .Dec 7 2021, 12:14 PM
hum_semihalf.com added a child revision: D33319: sdhci_fsl_fdt: Fix vccq reconfiguration .Dec 7 2021, 12:19 PM
hum_semihalf.com added a child revision: D33320: sdhci_fsl_fdt: Add support for HS200/HS400 modes .Dec 7 2021, 12:22 PM
bz accepted this revision.Dec 7 2021, 2:33 PM
bz added a subscriber: bz.

Is there a (public) reference for the errata? Might be worth mentioning that at least in the commit message.

sys/dev/sdhci/sdhci_fsl_fdt.c
743

technically you are only clearing a bit and not setting the register to 0...

Closed by commit rG3785106a5bd9: sdhci_fsl_fdt: Implement pulse width detection errata (authored by hum_semihalf.com, committed by wma). · Explain WhyDec 8 2021, 8:35 AM
This revision was automatically updated to reflect the committed changes.
wma added a commit: rG3785106a5bd9: sdhci_fsl_fdt: Implement pulse width detection errata.

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
22 lines

Diff 99690

View Options

sys/dev/sdhci/sdhci_fsl_fdt.c

Loading...