Page MenuHomeFreeBSD
Differential D32658

bhyve: initial Active Firmware Info for NVMe controller
ClosedPublic
Actions

Authored by wanpengqian_gmail.com on Oct 26 2021, 7:13 AM.
Tags
None
Referenced Files
F161339032: D32658.id.diff
Thu, Jul 2, 11:20 PM
Unknown Object (File)
Tue, Jun 30, 4:48 AM
Unknown Object (File)
Mon, Jun 29, 2:57 PM
Unknown Object (File)
Sat, Jun 27, 1:44 AM
Unknown Object (File)
Fri, Jun 26, 8:55 PM
Unknown Object (File)
Wed, Jun 24, 11:44 AM
Unknown Object (File)
May 18 2026, 6:55 AM
Unknown Object (File)
May 16 2026, 1:05 PM
View All Files
Subscribers
bcran
dab
imp
rgrimes

Details

Reviewers
chuck
jhb
markj
imp
Group Reviewers
bhyve
Commits
rG839b6e33089b: bhyve nvme: Fix Active Firmware Info
rG3cae10048d27: bhyve nvme: Fix Active Firmware Info
Summary

Currently Active Firmware Info is not initialized.
this patch will initial Active Firmware Info to slot 1.

Test Plan

Within FreeBSD/Linux guests, show the Firmware Logpage to confirm.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42364
Build 39252: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Oct 26 2021, 7:13 AM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 26 2021, 7:13 AM
Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript
wanpengqian_gmail.com requested review of this revision.Oct 26 2021, 7:13 AM
Harbormaster completed remote builds in B42364: Diff 97454.Oct 26 2021, 7:13 AM
wanpengqian_gmail.com added a reviewer: markj.Nov 29 2021, 10:14 PM
wanpengqian_gmail.com edited reviewers, added: imp; removed: grehan.Jan 12 2022, 6:20 AM
wanpengqian_gmail.com added a comment.Mar 25 2022, 4:10 AM

Any comments on this?
Obviously guest OS will work properly without this patch, but we can make the simulation more real.

chuck accepted this revision as: chuck.Mar 27 2022, 1:58 PM
This revision is now accepted and ready to land.Mar 27 2022, 1:58 PM
Closed by commit rG3cae10048d27: bhyve nvme: Fix Active Firmware Info (authored by wanpengqian_gmail.com, committed by chuck). · Explain WhyAug 14 2022, 6:19 PM
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG3cae10048d27: bhyve nvme: Fix Active Firmware Info.
corvink added a commit: rG839b6e33089b: bhyve nvme: Fix Active Firmware Info.Nov 14 2022, 8:26 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
5 lines

Diff 97454

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...