Differential D31835

altq: mark callouts as mpsafe
ClosedPublic
Actions

Authored by kp on Sep 4 2021, 2:23 PM.

Details

Reviewers

mav

Group Reviewers

network

Commits

rG312f5f8a4fb9: altq: mark callouts as mpsafe

Summary

There's no reason to acquire the Giant lock while executing the ALTQ
callouts.

While here also remove a few backwards compatibility defines for long
obsolete FreeBSD versions.

Suggested by: mav

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41371
Build 38260: arc lint + arc unit

Event Timeline

kp created this revision.Sep 4 2021, 2:23 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSep 4 2021, 2:23 PM

kp requested review of this revision.Sep 4 2021, 2:23 PM

Harbormaster completed remote builds in B41369: Diff 94656.Sep 4 2021, 2:24 PM

Thank you. There is one more in altq_subr.c in init_machclk_setup().

This revision is now accepted and ready to land.Sep 4 2021, 2:34 PM

Add missed callout

This revision now requires review to proceed.Sep 4 2021, 2:47 PM

Harbormaster completed remote builds in B41371: Diff 94658.Sep 4 2021, 2:47 PM

mav accepted this revision.Sep 4 2021, 3:12 PM

This revision is now accepted and ready to land.Sep 4 2021, 3:12 PM

Closed by commit rG312f5f8a4fb9: altq: mark callouts as mpsafe (authored by kp). · Explain WhySep 4 2021, 6:47 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG312f5f8a4fb9: altq: mark callouts as mpsafe.

Revision Contents
Changeset List

Path

Size

sys/

net/

altq/

altq_subr.c

4 lines

altq_var.h

9 lines

Diff 94658

View Options

sys/net/altq/altq_subr.c