Allow user to specify the IP address available for gdb
debugger.
I even wonder if we should't change the default from ANY to
localhost.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 38466 Build 35355: arc lint + arc unit
Event Timeline
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1855 | I'd prefer the default was the loopback address (rfb defaults to that). | |
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1855 | I agree, I just wasn't sure if we want to change the default. Currently we are listening to ANY. | |
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1855 | I'll say it's fine, and can be changed later if there's disagreement. | |
Comment Actions
Though this is not exactly a normal service, to me listening on any by default is the correct thing to do here. One thing I would like to note, this code appears to only listens on one of IPv4 or IPv6, which is probably a short coming.
| usr.sbin/bhyve/bhyverun.c | ||
|---|---|---|
| 490 | I would go ahead and use "gdb.address" as the name. | |
| 1446 | This won't actually work due to the way get_config_value works (it uses a single static buffer in case it has to do any variable expansion, so the next call to get_config_* invalidates any previously-returned char *. The old code ran atoi() before calling get_config_bool_default() which was ok, but the new code can't do that. Probably should just move the parsing into init_gdb() instead and call init_gdb() unconditionally. | |
| usr.sbin/bhyve/gdb.c | ||
| 1855 |
I think qemu defaults to localhost and that's probably better to do (as well as generally safer to not expose the debug port on a network by default). I wonder if it would be better though to use "localhost" rather than the numbers? Then you can get a dual-stack socket from getaddrinfo()? | |
| usr.sbin/bhyve/bhyverun.c | ||
|---|---|---|
| 1446 | Oh, I didn't notice that. I have look into the function and seen that you are using nvlist under hood and assume that you are just returning the value. As I test it only with the static texts I got two different pointers and everything look good. Your suggestion makes sense for me. | |
| usr.sbin/bhyve/gdb.c | ||
| 1855 | I will change the default in separate commit. | |
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1822 | You can't do this parsing here as it breaks config files. You would need to parse the command line option and set 'gdb.wait', 'gdb.address', and 'gdb.port' over in main() in the getopt() loop. However, init_gdb() would just use get_config_value() directly instead of taking the port and wait bool as arguments. | |
Comment Actions
Codewise this looks fine. I had one comment about permitting hostnames. Also, the new gdb.address variable should be documented in bhyve_config.5.
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1886 | Are we certain we want AI_NUMERICHOST vs allowing hostnames? If we don't give AI_NUMERICHOST, then the followup change to default to localhost can remove the #ifdef's above and just use "localhost" as the default address. | |
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1886 | One problem with allowing hostnames here (which the committed diff does) is that they can't begin with "w" since we use that character to decide whether or not to set gdb.wait. I think we need an alternate syntax. | |
| usr.sbin/bhyve/gdb.c | ||
|---|---|---|
| 1886 | '-o gdb.address=<hostname>' should work for hostnames that start with a 'w'. We should perhaps document this limitation though? In general I'd like to move towards using the config vars via -o. For example, I think it's fine to add new config options that can only be set via '-o' without adding a corresponding "short" option going forward. | |