Details

Reviewers

dteske
bcr
cperciva

Group Reviewers

manpages
Contributor Reviews (src)

Commits

rG73e1e1614f07: freebsd-update(8): Add -j flag to support jails
rGe02bf0022e90: freebsd-update(8): Add -j flag to support jails
rGc76da1f01064: freebsd-update(8): Add -j flag to support jails

Summary

Make freebsd-update(8) support jails by adding the -j flag which takes jail jid or name as an argument. This requires and depends on D25705 since it uses freebsd-version -j jail to get the version of the installed userland.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35353
Build 32279: arc lint + arc unit

Event Timeline

kfv_kfv.io created this revision.Jul 18 2020, 12:24 AM

Herald added a reviewer: manpages. · View Herald TranscriptJul 18 2020, 12:24 AM

Herald added a subscriber: imp. · View Herald Transcript

kfv_kfv.io requested review of this revision.Jul 18 2020, 12:24 AM

Harbormaster completed remote builds in B32391: Diff 74606.Jul 18 2020, 12:24 AM

bcr requested changes to this revision.Jul 18 2020, 9:38 AM

bcr added a subscriber: bcr.

bcr added inline comments.

usr.sbin/freebsd-update/freebsd-update.8
99 ↗	(On Diff #74606)	s/the/The/
101 ↗	(On Diff #74606)	The sentence stop is missing here.

This revision now requires changes to proceed.Jul 18 2020, 9:38 AM

Fixed. My apologies.

Harbormaster completed remote builds in B32395: Diff 74610.Jul 18 2020, 9:56 AM

lwhsu added a reviewer: cperciva.Jul 19 2020, 1:47 PM

The man page looks good now, thanks!

Any updates on the src part of the change?

0mp added a subscriber: 0mp.Aug 4 2020, 8:33 AM

Awaiting @dteske's review.

I think we won't progress here if we don't get someone else to review the src parts.
@cperciva: Can you take a look at it?

Just a simple bogon in the src bits, after which I will approve

usr.sbin/freebsd-update/freebsd-update.sh
332	I would use NR instead of FNR here simply because FNR has the additional complexity that it will reset to 1 when working on the next file, but when used to process a pipe stream it is in-essence working on a single file (/dev/stdin) and thus NR and FNR are always aligned making the use of FNR a bit of a bogon

This revision now requires changes to proceed.Dec 11 2020, 4:43 PM

Fixed. Thanks for the neat point, I'll keep it in mind.

Herald added a subscriber: andrew. · View Herald TranscriptDec 11 2020, 8:46 PM

Harbormaster completed remote builds in B35352: Diff 80600.Dec 11 2020, 8:47 PM

Fixing my previous mistake - my apologies.

Harbormaster completed remote builds in B35353: Diff 80602.Dec 11 2020, 8:58 PM

Sorry again, it must be good this time.

Harbormaster completed remote builds in B35354: Diff 80603.Dec 11 2020, 9:00 PM

@bcr: I think we could proceed now. Please note, that a very little change was made in D25705 where this diff relies on, and if you or anyone approve differentials, I think we can have them landed in 13.0-RELEASE, right? Please let me know if there is anything else I need to improve and update.

kfv_kfv.io added a reviewer: Contributor Reviews (src).Apr 19 2021, 8:18 AM

kfv_kfv.io changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.May 1 2021, 5:44 AM