Page MenuHomeFreeBSD
Differential D24352

Add LS1046A clockgen driver.
ClosedPublic
Actions

Authored by dgr_semihalf.com on Apr 9 2020, 2:49 PM.
Tags
None
Referenced Files
F103291715: D24352.diff
Sat, Nov 23, 3:35 AM
Unknown Object (File)
Sun, Nov 3, 1:31 AM
Unknown Object (File)
Oct 8 2024, 12:50 AM
Unknown Object (File)
Oct 1 2024, 3:30 PM
Unknown Object (File)
Sep 30 2024, 3:51 PM
Unknown Object (File)
Sep 29 2024, 9:33 AM
Unknown Object (File)
Sep 18 2024, 4:52 PM
Unknown Object (File)
Sep 18 2024, 7:12 AM
View All Files
Subscribers
andrew
emaste
imp
mmel

Details

Reviewers
mw
manu
mmel
Commits
rS361459: Add LS1046A clockgen driver.
Summary

Driver provides probe and attach functions for LS1046A clockgen and passes
configuration information to QorIQ clockgen class. May be used as
reference implementation for different QorIQ clockgen devices.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dgr_semihalf.com created this revision.Apr 9 2020, 2:49 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptApr 9 2020, 2:49 PM
dgr_semihalf.com added a parent revision: D24351: Add QorIQ platform clockgen driver..Apr 9 2020, 2:49 PM
dgr_semihalf.com added a child revision: D24353: Add GPIO support for QorIQ boards..Apr 9 2020, 3:04 PM
manu added a comment.Apr 11 2020, 11:09 AM

This is a comment for all the LS1046A reviews: Please add a new SOC_NXP_LS1046A option to sys/conf/options.arm64 and make the drivers depend on that in sys/conf/files.arm64
Thanks

dgr_semihalf.com updated this revision to Diff 71196.Apr 30 2020, 6:14 PM

I modified the driver to use the modified QorIQ clockgen classes.
Also added dependency on SOC_NXP_LS104A.

manu added inline comments.Apr 30 2020, 8:22 PM
sys/arm64/qoriq/clk/ls1046a_clkgen.c
174

this is the same id as the hwaccel1, is that intentional ?
If the clocks aren't exposed in the DTS an id of 0 is perfectly fine.

214

Why does this fixed clock needs a init function to be registered ?

dgr_semihalf.com added inline comments.May 7 2020, 12:26 PM
sys/arm64/qoriq/clk/ls1046a_clkgen.c
174

No, that was not intentional.
Most of the clocks are exposed in dts, but due to using two clock cells in dts the custom ofw_mapper function finds clock based on name instead of id.

214

I used init function here as the way FMAN nodes work is specific to SoC, so different way of creating this node may be needed.

dgr_semihalf.com added a comment.May 12 2020, 2:01 PM

Hi, if you have any more comments or remarks, please let me know. Thanks.

mmel added a subscriber: mmel.May 14 2020, 10:46 AM

Imho, It will be better to wait with this until we find consensus with D24351, right ?

sys/arm64/qoriq/clk/ls1046a_clkgen.c
60

There is no reason to obfuscate clock node name in this way, please use names from TRM

127

huh!. Use nitems() :)

174

again this is wrong way. Simply encode both cells into one id and use it.

dgr_semihalf.com updated this revision to Diff 72072.May 21 2020, 11:26 AM

Modified to work with new version of D24351

mmel accepted this revision.May 22 2020, 12:46 PM

The LS family has too many members and can share 99% of the code. It seems unnecessary for me to have the option for each individual variant. How about 'SOC_NXP_LS' ?

This revision is now accepted and ready to land.May 22 2020, 12:46 PM
dgr_semihalf.com added a comment.May 22 2020, 2:35 PM

I'll change it in all the patches to SOC_NXP_LS.

manu added a comment.May 22 2020, 2:36 PM
In D24352#549462, @mmel wrote:

The LS family has too many members and can share 99% of the code. It seems unnecessary for me to have the option for each individual variant. How about 'SOC_NXP_LS' ?

That might be fine for now but what about the future ?

mw added a comment.May 22 2020, 2:45 PM

@mmel @manu Please agree on the desired option naming as it affects all submitted patches. Once done, I'll commit.

manu added a comment.May 22 2020, 3:35 PM

Just go with NXP_LS, if there is any problem later we'll handle it at this moment.

manu accepted this revision.May 22 2020, 3:35 PM
mw added a comment.May 22 2020, 3:43 PM

Ok, thanks.

mmel added a comment.May 22 2020, 3:54 PM

from IRC:
There is at least 11 variants of QoriQ arm64 based SoCs. This is too much for per-SOC options.
We can always add a SOC_NXP_LS_BLAH and !it if one soc differs

dgr_semihalf.com updated this revision to Diff 72137.May 22 2020, 7:58 PM

Replace SOC_NXP_LS1046 with SOC_NXP_LS.

This revision now requires review to proceed.May 22 2020, 7:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2020, 2:45 PM
Closed by commit rS361459: Add LS1046A clockgen driver. (authored by mw). · Explain Why
This revision was automatically updated to reflect the committed changes.
mw added a commit: rS361459: Add LS1046A clockgen driver..
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2020, 2:45 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
1 line
qoriq/
clk/
255 lines
conf/
3 lines
1 line

Diff 72137

View Options

sys/arm64/conf/GENERIC

Loading...
View Options

sys/arm64/qoriq/clk/ls1046a_clkgen.c

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/options.arm64

Loading...