sys/arm/allwinner/aw_usbphy.c
432	Should the device_resume and device_suspend methods do anything?
438	I like better when you initialize by record: driver = { .name = "", .xxxx .size = .... }; Current code is OK. Same with other drivers in this patch.

This revision is now accepted and ready to land.Apr 8 2016, 12:07 PM

andrew added inline comments.Apr 8 2016, 12:35 PM

sys/dev/usb/controller/musb_otg.c
3146 ↗	(On Diff #15002)	(Why the extra parentheses?)

jmcneill added inline comments.Apr 8 2016, 12:36 PM

sys/dev/usb/controller/musb_otg.c
3146 ↗	(On Diff #15002)	Old code was like this, I only changed the indentation.

jmcneill added inline comments.Apr 8 2016, 12:44 PM

sys/arm/allwinner/aw_usbphy.c
432	Suspend/resume not yet supported on the Allwinner port.
438	Agree, but following style used in the rest of sys/arm/allwinner. Would it be alright if I changed musb_otg_allwinner.c to use C99 initializers and left awusbphy.c as-is?

Tweak the attach order of aw_usbphy and use c99 initializers in declaration of awusbdrd_driver

This revision now requires review to proceed.Apr 9 2016, 11:16 AM

• hselasky accepted this revision.Apr 9 2016, 7:36 PM

• hselasky edited edge metadata.

This revision is now accepted and ready to land.Apr 9 2016, 7:36 PM

This is on hold due to an issue that showed up on Banana Pi testing. The board has two micro USB ports (OTG + power), and if the board is powered by the OTG port, configuring the PHY for host mode causes the board to reset. Ideally we will want to take ID and VBUS detect signaling into consideration (status which, depending on the board, is either read from GPIO pins, the AXP PMU, or both).

Ping - any news?

No news yet. The PHY driver has had some changes since this patch was last updated, so first I will need to merge with head.

emaste added a subscriber: emaste.Nov 14 2017, 2:20 PM

kevans added a subscriber: kevans.Nov 15 2017, 2:21 PM

andrew commandeered this revision.Feb 27 2018, 2:16 PM

andrew added a reviewer: jmcneill.

Herald added a reviewer: manu. · View Herald TranscriptFeb 27 2018, 2:16 PM

This revision now requires review to proceed.Feb 27 2018, 2:16 PM

Update to catch up with changed KPI and work on arm64 on the sopine.
This is untested on 32-bit arm.

Harbormaster completed remote builds in B15298: Diff 39789.Feb 27 2018, 2:20 PM

It doesn't seem to quite work on the Allwinner A64. I'm getting the following when I try to use a wifi dongle:

...
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
...

Handle missing CONFDATA register on some platforms

Harbormaster completed remote builds in B15305: Diff 39796.Feb 27 2018, 4:34 PM

We don't have sc in awusbdrd_bs_r_1 to check

Harbormaster completed remote builds in B15306: Diff 39797.Feb 27 2018, 4:48 PM

You need to ensure the chip actually supports the number of channels you specify.

Include D14783 to allow us to set our own endpoint config

Harbormaster completed remote builds in B15683: Diff 40535.Mar 21 2018, 1:42 PM

• hselasky added inline comments.Mar 21 2018, 2:17 PM

sys/dev/usb/controller/musb_otg.h
432 ↗	(On Diff #40535)	Spelling error? sc_eb_cfg -> sc_ep_cfg

andrew mentioned this in D14783: Use a table to find the endpoint configuration.Mar 21 2018, 3:12 PM

andrew added inline comments.Mar 21 2018, 3:13 PM

sys/dev/usb/controller/musb_otg.h
432 ↗	(On Diff #40535)	I've fixed it in D14783. I'll rebase this when that's been committed.

Rebase

Harbormaster completed remote builds in B15726: Diff 40608.Mar 22 2018, 6:52 PM

manu added inline comments.Mar 22 2018, 7:55 PM

sys/dev/usb/controller/musb_otg_allwinner.c
70	s/allwinner_machdep/aw_machdep/

Fix an include

Harbormaster completed remote builds in B15737: Diff 40632.Mar 23 2018, 10:35 AM

andrew marked an inline comment as done.Mar 23 2018, 10:35 AM

musb_otg.c part looks fine

This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2018, 11:09 AM

Closed by commit rS331421: If sc->sc_ep_max is already set use it to find the number of RX and TX (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew reopened this revision.Mar 23 2018, 11:09 AM

Rebase

Harbormaster completed remote builds in B15738: Diff 40634.Mar 23 2018, 11:10 AM

linimon added a subscriber: linimon.Mar 24 2018, 6:34 PM

My problem was clock related (which I've fixed this weekend) and using latest u-boot which have usb problem ...
You probably didn't have the error as u-boot setup the clocks for you, now that we correctly set the clocks it's working.

This revision is now accepted and ready to land.Jun 25 2018, 5:15 AM

linimon removed a subscriber: linimon.May 10 2019, 12:14 AM

thj added a reviewer: thj.Jul 20 2019, 2:43 PM

Any strong reason this is not in the tree yet?
Thanks!

In D5881#577758, @avg wrote:

Any strong reason this is not in the tree yet?
Thanks!

I don't think so, maybe there is a bit of stuff to do with regulator but if the driver still works that could be commited and we'll deal with regulator later.

Feel free to push upstream if the code has been tested.

Closed by commit rS365398: Allwinner USB DRD support (musb_otg) (authored by avg). · Explain WhySep 7 2020, 6:39 AM

This revision was automatically updated to reflect the committed changes.

avg added a commit: rS365398: Allwinner USB DRD support (musb_otg).

Allwinner USB DRD support (musb_otg)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40634

sys/arm/allwinner/aw_usbphy.c

sys/arm/allwinner/files.allwinner

sys/arm64/conf/GENERIC

sys/conf/files.arm64

sys/dev/usb/controller/musb_otg_allwinner.c

Allwinner USB DRD support (musb_otg)ClosedPublicActions