Allwinner USB DRD support (musb_otg)

[andrew]

Summary

Allwinner USB DRD is based on the Mentor USB OTG controller, with a different register layout and a few missing registers.

[• hselasky]

sys/arm/allwinner/aw_usbphy.c

173

Should the device_resume and device_suspend methods do anything?

179

I like better when you initialize by record:

driver = {
.name = "",
.xxxx
.size = ....
};

Current code is OK.

Same with other drivers in this patch.

[andrew]

sys/dev/usb/controller/musb_otg.c

3146

(Why the extra parentheses?)

[jmcneill]

sys/dev/usb/controller/musb_otg.c

3146

Old code was like this, I only changed the indentation.

[jmcneill]

sys/arm/allwinner/aw_usbphy.c

173

Suspend/resume not yet supported on the Allwinner port.

179

Agree, but following style used in the rest of sys/arm/allwinner. Would it be alright if I changed musb_otg_allwinner.c to use C99 initializers and left awusbphy.c as-is?

[jmcneill]

Tweak the attach order of aw_usbphy and use c99 initializers in declaration of awusbdrd_driver

[jmcneill]

This is on hold due to an issue that showed up on Banana Pi testing. The board has two micro USB ports (OTG + power), and if the board is powered by the OTG port, configuring the PHY for host mode causes the board to reset. Ideally we will want to take ID and VBUS detect signaling into consideration (status which, depending on the board, is either read from GPIO pins, the AXP PMU, or both).

[• hselasky]

Ping - any news?

[jmcneill]

No news yet. The PHY driver has had some changes since this patch was last updated, so first I will need to merge with head.

[andrew]

Update to catch up with changed KPI and work on arm64 on the sopine.
This is untested on 32-bit arm.

[andrew]

It doesn't seem to quite work on the Allwinner A64. I'm getting the following when I try to use a wifi dongle:

...
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
...

[andrew]

Handle missing CONFDATA register on some platforms

[andrew]

We don't have sc in awusbdrd_bs_r_1 to check

[• hselasky]

You need to ensure the chip actually supports the number of channels you specify.

[andrew]

Include D14783 to allow us to set our own endpoint config

[• hselasky]

sys/dev/usb/controller/musb_otg.h

432 ↗

(On Diff #40535)

Spelling error? sc_eb_cfg -> sc_ep_cfg

[andrew]

sys/dev/usb/controller/musb_otg.h

432 ↗

(On Diff #40535)

I've fixed it in D14783. I'll rebase this when that's been committed.

[andrew]

Rebase

[manu]

sys/dev/usb/controller/musb_otg_allwinner.c

70

s/allwinner_machdep/aw_machdep/

[andrew]

Fix an include

[• hselasky]

musb_otg.c part looks fine

[andrew]

Rebase

[manu]

My problem was clock related (which I've fixed this weekend) and using latest u-boot which have usb problem ...
You probably didn't have the error as u-boot setup the clocks for you, now that we correctly set the clocks it's working.

[avg]

Any strong reason this is not in the tree yet?
Thanks!

[manu]

In D5881#577758, @avg wrote:

Any strong reason this is not in the tree yet?
Thanks!

I don't think so, maybe there is a bit of stuff to do with regulator but if the driver still works that could be commited and we'll deal with regulator later.

[• hselasky]

Feel free to push upstream if the code has been tested.