asmc: split the debug key access into asmc_debug.c
ClosedPublic
Actions

Authored by seuros on Sat, Nov 7, 4:56 PM.

Project Tags

None

Referenced Files

	F177426620: D61294.1794354078.diff
	Mon, Nov 9, 11:41 PM

	F177410103: D61294.1794310714.diff
	Mon, Nov 9, 11:38 AM

	F177405723: D61294.1794302869.diff
	Mon, Nov 9, 9:27 AM

Subscribers

imp

Details

Reviewers

adrian
ngie

Group Reviewers

drivers

Commits

rGd412f42e5377: asmc: split the debug key access into asmc_debug.c

Summary

Move the ASMC_DEBUG code out of asmc.c into a file compiled only when the
option is set, gated in files.amd64 the way acpi_debug gates the ACPICA
debugger sources. The module Makefile writes the define into opt_asmc.h so
every translation unit sees it; the old CFLAGS.asmc.c form covered one.

No functional change.

MFC After: 1 Week
Approved-by: ngie (co-mentor)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 78819
Build 75702: arc lint + arc unit

Event Timeline

seuros created this revision.Sat, Nov 7, 4:56 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 7, 4:56 PM

seuros requested review of this revision.Sat, Nov 7, 4:56 PM

Harbormaster completed remote builds in B78819: Diff 191828.Sat, Nov 7, 4:56 PM

seuros added a parent revision: D61293: asmc: move the sysctl registration loops next to their tables.Sat, Nov 7, 5:32 PM

seuros added a child revision: D61295: acpi_apple: Fix sleep with non-sleepable lock held.

seuros removed a child revision: D61295: acpi_apple: Fix sleep with non-sleepable lock held.

seuros added a child revision: D61296: asmc: split the PIO backend into asmcpio.c.

rename

Harbormaster completed remote builds in B78851: Diff 191892.Sun, Nov 8, 9:39 AM

ngie retitled this revision from asmc: split the debug key access into asmcdebug.c to asmc: split the debug key access into asmc_debug.c.Mon, Nov 9, 2:42 AM

ngie added inline comments.Mon, Nov 9, 3:04 AM

sys/dev/asmc/asmc_debug.c
90 ↗	(On Diff #191892)	style(9) says to do this. Feel free to do it in a separate review though if you're trying to make the changes iteratively with the smallest diff possible between changes (this applies to all of the other instances I highlighted).
108–109 ↗	(On Diff #191892)	Patterns like this make me feel like we should have a `CLAMP` macro like Linux for the sake of explicitness.
124 ↗	(On Diff #191892)
165 ↗	(On Diff #191892)
174 ↗	(On Diff #191892)
sys/dev/asmc/asmc_debug.h
12 ↗	(On Diff #191892)
sys/dev/asmc/asmcvar.h
30–36	Should this be in `asmc_debug.h` instead?