Page MenuHomeFreeBSD
Differential D60799

libc: Export timespec_getres(3)
Needs ReviewPublic
Actions

Authored by kfv on Sat, Oct 17, 9:17 AM.
Tags
None
Referenced Files
F176537888: D60799.id190098.diff
Mon, Oct 19, 4:01 PM
F176481382: D60799.diff
Mon, Oct 19, 5:20 AM
Unknown Object (File)
Sun, Oct 18, 10:49 PM
Unknown Object (File)
Sun, Oct 18, 10:34 PM
Unknown Object (File)
Sun, Oct 18, 4:03 PM
Unknown Object (File)
Sun, Oct 18, 12:46 AM
Unknown Object (File)
Sat, Oct 17, 8:02 PM
Unknown Object (File)
Sat, Oct 17, 7:19 PM
View All 14 Files
Subscribers
imp

Details

Reviewers
dteske
fuz
des
Summary

timespec_getres() has been declared in <time.h> and built into libc,
but never listed in a symbol map. It is therefore local to libc.so,
and dynamically linked callers fail to link.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78290
Build 75173: arc lint + arc unit

Event Timeline

kfv created this revision.Sat, Oct 17, 9:17 AM
Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 17, 9:17 AM
kfv requested review of this revision.Sat, Oct 17, 9:17 AM
Harbormaster completed remote builds in B78290: Diff 190098.Sat, Oct 17, 9:17 AM
fuz added a comment.Sun, Oct 18, 12:39 PM

Good catch!

Might be a good opportunity to add a companion unit test.

lib/libc/gen/Symbol.map
443

This needs to go in FBSD_1.9 in my opinion, as the symbol was only added to the interface at that point. That we had it as an unexported interface before is an accident, but does not affect the versioning.

des added a comment.Mon, Oct 19, 2:42 PM

Please add an appropriate Fixes: line

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
1 line

Diff 190098

View Options

lib/libc/gen/Symbol.map

Loading...