hwpmc: release a PMC whose ID could not be copied out
Needs ReviewPublic
Actions

Authored by afscoelho_gmail.com on Sat, Oct 10, 1:21 AM.

Tags

None

Referenced Files

	F175715074: D60562.diff
	Mon, Oct 12, 5:46 PM

	Unknown Object (File)
	Sun, Oct 11, 10:15 AM

	Unknown Object (File)
	Sun, Oct 11, 5:25 AM

	Unknown Object (File)
	Sun, Oct 11, 12:52 AM

	Unknown Object (File)
	Sat, Oct 10, 4:26 PM

	Unknown Object (File)
	Sat, Oct 10, 6:37 AM

	Unknown Object (File)
	Sat, Oct 10, 6:25 AM

	Unknown Object (File)
	Sat, Oct 10, 4:22 AM

View All 13 Files

Subscribers

imp

Details

Reviewers

mhorne
gnn
ali_mashtizadeh.com

Group Reviewers

pmc

Summary

If copyout of the new PMC ID fails, the caller cannot use or release
the PMC. Release it in the kernel.

Test Plan

Built amd64 GENERIC + hwpmc.ko, GENERIC without HWPMC_HOOKS, and arm64.
Ran tests/sys/pmc on AMD Zen 6 (LBR v2).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77935
Build 74818: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Sat, Oct 10, 1:21 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 10, 1:21 AM

afscoelho_gmail.com requested review of this revision.Sat, Oct 10, 1:21 AM

Harbormaster completed remote builds in B77935: Diff 189317.Sat, Oct 10, 1:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_mod.c

6 lines

Diff 189317

View Options

hwpmc: release a PMC whose ID could not be copied outNeeds ReviewPublicActions