Details

Reviewers

jlduran
jrm
ashish

Summary

Fetch pkgbase packages into a local repository (FreeBSD-local) before installing. Rewrite _xxx_pkg_metalog() to deduplicate METALOG entries and split target database regeneration into _xxx_run_pkg_scripts().

Add metalog_add_data() to append metalog lines with sensible mode defaults.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76296
Build 73179: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:18 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:18 AM

senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:18 AM

Harbormaster completed remote builds in B75709: Diff 184321.Wed, Aug 19, 10:18 AM

senguptaangshuman17_gmail.com added a parent revision: D58955: nanobsd: Update pkg database sha256 and config content.Wed, Aug 19, 10:18 AM

senguptaangshuman17_gmail.com added a child revision: D58957: nanobsd: Remove chflags call in install_world().

senguptaangshuman17_gmail.com updated this revision to Diff 184456.Thu, Aug 20, 10:10 AM

Harbormaster completed remote builds in B75790: Diff 184456.Thu, Aug 20, 10:10 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184504.Thu, Aug 20, 12:21 PM

Harbormaster completed remote builds in B75833: Diff 184504.Thu, Aug 20, 12:21 PM

senguptaangshuman17_gmail.com edited parent revisions, added: D59043: nanobsd: Add _xxx_pkg_metalog; removed: D58955: nanobsd: Update pkg database sha256 and config content.Thu, Aug 20, 12:33 PM

Rename revision, normalize XXXJL comments, restore normalized fingerprints comment

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 7:02 PM

Harbormaster completed remote builds in B75911: Diff 184597.Thu, Aug 20, 7:02 PM

senguptaangshuman17_gmail.com added a child revision: D58959: nanobsd: Disable pkg repositories on target image.Thu, Aug 20, 7:04 PM

senguptaangshuman17_gmail.com retitled this revision from nanobsd: Fix package base metalog and installation issues to nanobsd: Use local repository cache for precompiled package base builds.

senguptaangshuman17_gmail.com removed a child revision: D58959: nanobsd: Disable pkg repositories on target image.Thu, Aug 20, 7:16 PM

lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:15 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184831.Sun, Aug 23, 11:02 PM

Harbormaster completed remote builds in B76017: Diff 184831.Sun, Aug 23, 11:02 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184968.Tue, Aug 25, 6:11 AM

Harbormaster completed remote builds in B76091: Diff 184968.Tue, Aug 25, 6:11 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76117: Diff 184994.Tue, Aug 25, 7:59 AM

jlduran added inline comments.Wed, Aug 26, 2:49 PM

tools/tools/nanobsd/defaults.sh
304	This change should be done in D58950.
370	This change should be done in D58952.
490	This comment change is not related to this commit, I believe it should be done in D58951.
522	This comment change is not related to this commit, I believe it should be done in D58954.
594	This change should be done in D58951.
881–895	This (location) change should be done in D58931. It is a non-functional change (NFC) that just changes the location of the function to keep it together (alphabetically?) with other `tgt_` functions.