Paths

Table of Contentst

Differential D59113

ptrace(PT_GET_ABI_NAME)
ClosedPublic
Actions

Authored by kib on Aug 22 2026, 11:07 PM.

Tags

None

Referenced Files

	F174987274: D59113.id184758.diff
	Wed, Oct 7, 10:20 AM

	Unknown Object (File)
	Tue, Oct 6, 6:34 PM

	Unknown Object (File)
	Sat, Oct 3, 5:37 PM

	Unknown Object (File)
	Fri, Oct 2, 4:23 PM

	Unknown Object (File)
	Thu, Sep 24, 11:35 AM

	Unknown Object (File)
	Sun, Sep 20, 6:03 PM

	Unknown Object (File)
	Thu, Sep 17, 7:49 AM

	Unknown Object (File)
	Wed, Sep 16, 7:58 AM

Subscribers

Details

Reviewers

markj
jhb

Commits

rG3dfd63b58463: ptrace.2: document PT_GET_ABI_NAME
rG6b9ef5dfc903: ptrace(2): add PT_GET_ABI_NAME request

Summary

This covers the immediate need of truss(1), allowing to postpone pdkinfo(2).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Aug 22 2026, 11:07 PM

Herald added subscribers: ziaee, olce, emaste, imp. · View Herald TranscriptAug 22 2026, 11:07 PM

kib requested review of this revision.Aug 22 2026, 11:07 PM

Use the right target process.

markj added inline comments.Aug 24 2026, 1:39 PM

lib/libsys/ptrace.2
1111	Or "defines how system call numbers and arguments are interpreted." Or "the ABI selects the system call table used by the process."
1116	IMO this makes it slightly more obvious that the nul-terminator is included.
sys/compat/freebsd32/freebsd32_misc.c
1254	`udata <= strlen(...)` is a signed/unsigned comparison, no? Don't we thus need an explicit check for `udata < 0`?
sys/kern/sys_process.c
892	Same comment about negative `data`.
2047	Shouldn't truncation result in an error?

Fix signed/unsigned comparison.
Report error on too long ABI name.
Man page improvements.

markj accepted this revision.Aug 25 2026, 5:56 PM

This revision is now accepted and ready to land.Aug 25 2026, 5:56 PM

Closed by commit rG6b9ef5dfc903: ptrace(2): add PT_GET_ABI_NAME request (authored by kib). · Explain WhyAug 28 2026, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG6b9ef5dfc903: ptrace(2): add PT_GET_ABI_NAME request.

kib added a commit: rG3dfd63b58463: ptrace.2: document PT_GET_ABI_NAME.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

11 lines

sys/

compat/

freebsd32/

freebsd32_misc.c

12 lines

kern/

20 lines

sys/

1 line

Diff 184884

lib/libsys/ptrace.2

Loading...

sys/compat/freebsd32/freebsd32_misc.c

Loading...

sys/kern/sys_process.c

Loading...

sys/sys/ptrace.h

Loading...