Page MenuHomeFreeBSD
Differential D59113

ptrace(PT_GET_ABI_NAME)
ClosedPublic
Actions

Authored by kib on Sat, Aug 22, 11:07 PM.
Tags
None
Referenced Files
F171222178: D59113.id185339.diff
Wed, Sep 9, 3:19 PM
F171183732: D59113.id184758.diff
Wed, Sep 9, 8:13 AM
F171183212: D59113.id.diff
Wed, Sep 9, 8:07 AM
Unknown Object (File)
Tue, Sep 8, 5:01 PM
Unknown Object (File)
Tue, Sep 8, 3:58 PM
Unknown Object (File)
Tue, Sep 8, 12:11 PM
Unknown Object (File)
Tue, Sep 8, 4:54 AM
Unknown Object (File)
Tue, Sep 8, 12:17 AM
View All Files
Subscribers
emaste
imp
olce
ziaee

Details

Reviewers
markj
jhb
Commits
rG3dfd63b58463: ptrace.2: document PT_GET_ABI_NAME
rG6b9ef5dfc903: ptrace(2): add PT_GET_ABI_NAME request
Summary

This covers the immediate need of truss(1), allowing to postpone pdkinfo(2).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sat, Aug 22, 11:07 PM
Herald added subscribers: ziaee, olce, emaste, imp. · View Herald TranscriptSat, Aug 22, 11:07 PM
kib requested review of this revision.Sat, Aug 22, 11:07 PM
kib updated this revision to Diff 184762.Sun, Aug 23, 12:28 AM

Use the right target process.

markj added inline comments.Mon, Aug 24, 1:39 PM
lib/libsys/ptrace.2
1111

Or "defines how system call numbers and arguments are interpreted."

Or "the ABI selects the system call table used by the process."

1116

IMO this makes it slightly more obvious that the nul-terminator is included.

sys/compat/freebsd32/freebsd32_misc.c
1250

udata <= strlen(...) is a signed/unsigned comparison, no? Don't we thus need an explicit check for udata < 0?

sys/kern/sys_process.c
888

Same comment about negative data.

2043

Shouldn't truncation result in an error?

kib updated this revision to Diff 184884.Mon, Aug 24, 1:56 PM
kib marked 5 inline comments as done.

Fix signed/unsigned comparison.
Report error on too long ABI name.
Man page improvements.

markj accepted this revision.Tue, Aug 25, 5:56 PM
This revision is now accepted and ready to land.Tue, Aug 25, 5:56 PM
Closed by commit rG6b9ef5dfc903: ptrace(2): add PT_GET_ABI_NAME request (authored by kib). · Explain WhyFri, Aug 28, 12:05 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG6b9ef5dfc903: ptrace(2): add PT_GET_ABI_NAME request.
kib added a commit: rG3dfd63b58463: ptrace.2: document PT_GET_ABI_NAME.

Revision Contents
Changeset List

PathSize
lib/
libsys/
11 lines
sys/
compat/
freebsd32/
8 lines
kern/
15 lines
sys/
1 line

Diff 184762

View Options

lib/libsys/ptrace.2

Loading...
View Options

sys/compat/freebsd32/freebsd32_misc.c

Loading...
View Options

sys/kern/sys_process.c

Loading...
View Options

sys/sys/ptrace.h

Loading...