Page MenuHomeFreeBSD
Differential D58957

nanobsd: Remove chflags call in install_world()
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:19 AM.
Tags
None
Referenced Files
F167939500: D58957.id184322.diff
Tue, Aug 25, 12:57 PM
Unknown Object (File)
Tue, Aug 25, 5:49 AM
Unknown Object (File)
Tue, Aug 25, 5:47 AM
Unknown Object (File)
Mon, Aug 24, 5:21 PM
Unknown Object (File)
Mon, Aug 24, 3:05 PM
Unknown Object (File)
Mon, Aug 24, 12:49 PM
Unknown Object (File)
Mon, Aug 24, 8:28 AM
Unknown Object (File)
Mon, Aug 24, 5:42 AM
View All 24 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

clean_world() wipes NANO_WORLDDIR before install_world() runs, and
installworld itself never sets schg on installed files. Nothing
ever needs clearing, so the chflags -R noschg is dead code on both
privileged and unprivileged builds.

Sponsored by: Google LLC (GSoC 2026)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75834
Build 72717: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:19 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:19 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:19 AM
Harbormaster completed remote builds in B75710: Diff 184322.Wed, Aug 19, 10:19 AM
senguptaangshuman17_gmail.com added a parent revision: D58956: nanobsd: Use local repository cache for precompiled package base builds.Wed, Aug 19, 10:19 AM
senguptaangshuman17_gmail.com added a child revision: D58958: nanobsd: Fix pkg audit.
jlduran added a comment.Wed, Aug 19, 5:34 PM

I would recommend squashing the majority of this commit with D58931, as the changes are mostly NFC (the leftovers).

tools/tools/nanobsd/defaults.sh
965

This is a "functional" change and should be submitted separately.

senguptaangshuman17_gmail.com updated this revision to Diff 184457.Thu, Aug 20, 10:10 AM
Harbormaster completed remote builds in B75791: Diff 184457.Thu, Aug 20, 10:10 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184505.Thu, Aug 20, 12:22 PM
Harbormaster completed remote builds in B75834: Diff 184505.Thu, Aug 20, 12:22 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184598.Thu, Aug 20, 7:02 PM

Isolate functional change (disable chflags in install_world) and normalize comments

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 7:02 PM
Harbormaster completed remote builds in B75912: Diff 184598.Thu, Aug 20, 7:02 PM
senguptaangshuman17_gmail.com retitled this revision from nanobsd: Cleanup common functions to nanobsd: Disable chflags call in install_world().Thu, Aug 20, 7:04 PM
senguptaangshuman17_gmail.com added a child revision: D58959: nanobsd: Disable pkg repositories on target image.Thu, Aug 20, 7:16 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:15 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184832.Sun, Aug 23, 11:02 PM
Harbormaster completed remote builds in B76018: Diff 184832.Sun, Aug 23, 11:02 PM
imp added a comment.Sun, Aug 23, 11:04 PM

Commit message needs a why.

senguptaangshuman17_gmail.com updated this revision to Diff 184967.Tue, Aug 25, 6:11 AM
Harbormaster completed remote builds in B76090: Diff 184967.Tue, Aug 25, 6:11 AM
senguptaangshuman17_gmail.com retitled this revision from nanobsd: Disable chflags call in install_world() to nanobsd: Remove chflags call in install_world().Tue, Aug 25, 6:13 AM
senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)Tue, Aug 25, 6:25 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184995.Tue, Aug 25, 7:59 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76118: Diff 184995.Tue, Aug 25, 7:59 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
48 lines
7 lines

Diff 184505

View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...